Merged
Conversation
Contributor
Author
|
Scratch that.. I'll do that anyway cus the build seems to be failing somehow |
0b0114c to
0a9a10a
Compare
7d56062 to
61355fa
Compare
Contributor
Author
|
This is also ready for review now FYI |
61355fa to
d339bfe
Compare
duckdoom5
added a commit
to duckdoom5/CppSharp
that referenced
this pull request
Feb 27, 2025
Contributor
Author
|
Since this hasn't been merged yet, I'll just improve this commit a bit more today |
Collaborator
Cool, had just started a review actually 😄 |
Contributor
Author
|
@tritao This is ready for review now. Could still use some improvements, but that can be done in a later PR |
tritao
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.