fix(NODE-5106): prevent multiple mongo client connect()s from leaking topology#3596
Merged
baileympearson merged 11 commits intomongodb:mainfrom Mar 28, 2023
Merged
fix(NODE-5106): prevent multiple mongo client connect()s from leaking topology#3596baileympearson merged 11 commits intomongodb:mainfrom
baileympearson merged 11 commits intomongodb:mainfrom
Conversation
addaleax
reviewed
Mar 10, 2023
Contributor
addaleax
left a comment
There was a problem hiding this comment.
This generally seems like the right thing to do, but I think you'll need to add a test for this. Somebody from the team can probably confirm.
You probably don't need all the complexity of the resource_clean_up.test.ts file, I think you could just ensure that e.g. when you call client.connect() twice in the same tick, you'll stil only get one open event on the MongoClient.
Contributor
Author
|
Yes I clarified in the ticket why I did not add a test. I remain available |
baileympearson
suggested changes
Mar 13, 2023
nbbeeken
requested changes
Mar 21, 2023
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
Contributor
Author
|
Hey @nbbeeken, |
nbbeeken
previously approved these changes
Mar 28, 2023
nbbeeken
approved these changes
Mar 28, 2023
baileympearson
approved these changes
Mar 28, 2023
5 tasks
baileympearson
added a commit
that referenced
this pull request
Jun 1, 2023
… topology (#3596) Co-authored-by: Neal Beeken <neal.beeken@mongodb.com> Co-authored-by: Bailey Pearson <bailey.pearson@mongodb.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(NODE-5106): Add MongoClient connect lock mechanism to avoid topology leak
Description
Related to the ticket opened here : https://jira.mongodb.org/browse/NODE-5106
As mentionned in the issue, not test provided because atm a test cannot be performed according to the beforeHooks awaiting the MongoClient connect.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript