Skip to content

test(NODE-5033): fix handshake error message check#3558

Merged
baileympearson merged 1 commit intomainfrom
NODE-5033
Feb 7, 2023
Merged

test(NODE-5033): fix handshake error message check#3558
baileympearson merged 1 commit intomainfrom
NODE-5033

Conversation

@durran
Copy link
Copy Markdown
Contributor

@durran durran commented Feb 6, 2023 •
edited
Loading

Description

Fix the CSFLE handshake error test.

What is changing?

  • Check for both the old and new handshake error messages in the prose test.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5033

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review February 7, 2023 00:47
@baileympearson baileympearson merged commit bf69bd6 into main Feb 7, 2023
@baileympearson baileympearson deleted the NODE-5033 branch February 7, 2023 00:52
nbbeeken pushed a commit that referenced this pull request Feb 10, 2023
@durran @nbbeeken
test(NODE-5033): fix handshake error message check (#3558)
4462efd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@baileympearson baileympearson baileympearson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@durran @baileympearson