[JAVA-5203] Support stored nulls for non-primitive fields in Java records#1223
Merged
jyemin merged 4 commits intoOct 23, 2023
Merged
Conversation
jyemin
requested changes
Oct 20, 2023
jyemin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the Jira report and the pull request. I have a change request for you if you're inclined to keep working on this.
jyemin
requested changes
Oct 22, 2023
jyemin
left a comment
Collaborator
There was a problem hiding this comment.
One more change, please.
jyemin
approved these changes
Oct 23, 2023
jyemin
pushed a commit
that referenced
this pull request
Oct 23, 2023
Collaborator
|
Thanks for the contribution, @bulbfreeman |
Contributor
Author
|
OOI is there an expected date for the next version release that contains this change? @jyemin |
Collaborator
|
Yes, it should be released around Tuesday of next week. |
Contributor
Author
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Same as the issue raised in https://jira.mongodb.org/browse/JAVA-5134, this change implements a mechanism to gracefully handle stored nulls for fields that are annotated with JSR305
@Nullableannotations.Changes
isNullabletoRecordCodec.ComponentModel, which is set to true when given field is not primitive.BsonInvalidOperationException.Issue ticket
JAVA-5203