Do not get UPPERCASE env vars by wheezil · Pull Request #427 · mojohaus/exec-maven-plugin

wheezil · 2024-05-10T21:09:03Z

We hit this issue when we updated MSBuild to latest VS2022.
The problem original appears to be simply that maven-exec-plugin was adding both
EnvironmentVariable
and its twin that differs only by case
ENVIRONMENTVARIABLE
which was indeed a problem. However, simply removing the duplicates didn't work, because MSBuild is "special". Apparently, if you have an env var like OneDrive and maven-exec-plugin turns that into ONEDRIVE for the launched process environment block, MSBuild somehow finds the original env var definitions (in the registry?) and attempts to add them. It doesn't detect the duplicate that differs only in case until it is too late and it errors out as described in this MS bug report
The answer is trivially simple -- don't UPPERCASE the env vars

src/main/java/org/codehaus/mojo/exec/ExecMojo.java

wheezil · 2024-05-12T23:32:14Z

@slawekjaranowski thanks I made that change

src/main/java/org/codehaus/mojo/exec/ExecMojo.java

slawekjaranowski · 2024-05-13T06:22:35Z

please rebuild project with JDK 11+ to see errors from spotless

slawekjaranowski · 2024-05-13T06:51:44Z

Please also look at:
https://github.com/mojohaus/exec-maven-plugin/pull/427/files#diff-08636831c593bb3e17c86b9287a93a740b26c44a780252ddd4bf1537faddf3ebR496-R501

we can have a duplicate keys like Path and PATH

slawekjaranowski · 2024-05-13T06:55:46Z

Thera is also environmentVariables parameters
https://www.mojohaus.org/exec-maven-plugin/exec-mojo.html#environmentVariables

User can provide env values with different format

slawekjaranowski · 2024-05-21T19:17:23Z

@wheezil How's work going?

wheezil · 2024-05-21T19:43:08Z

Hi I am on vacation for a while, will get back to this in about a month

…

On Tue, May 21, 2024, 21:17 Slawomir Jaranowski ***@***.***> wrote: @wheezil <https://github.com/wheezil> How's work going? — Reply to this email directly, view it on GitHub <#427 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKXHCJKTCLGWU4AR6VBRJTZDOMVTAVCNFSM6AAAAABHRIE3RGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRTGI4DKNRVGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Making sure that my fork is up to date

wheezil · 2024-07-03T18:23:00Z

@slawekjaranowski how about now? The spotless plugin is flagging a bunch of files that are not my changes, but I did remove the unused import.

dermot-hardy · 2024-07-15T22:39:43Z

Hi. Is the SNAPSHOT version of the plugin that is built from this branch published anywhere? Thanks, Dermot.

wheezil · 2024-07-15T22:42:54Z

@dermot-hardy no I did not publish an artifact. We have one on our internal servers.
It is not hard to build the branch and give it whatever version you want locally. However, I had to disable the spotless plugin.

dermot-hardy · 2024-07-15T22:43:56Z

If it's an easy thing for you to do it would be much appreciated. I tried using https://jitpack.io/ but it looks like they use Maven 3.6.1 and this project requires Maven 3.6.3:
https://jitpack.io/com/github/wheezil/exec-maven-plugin/0731ed3780/build.log

wheezil · 2024-07-15T22:43:57Z

@slawekjaranowski Just seeing if this can be merged or is there something I have to do?

dermot-hardy · 2024-07-15T23:53:47Z

Just FYI I've forked your branch and added a couple of extra commits (see here) to allow it to build with Maven 3.8.1 so that I could get a https://jitpack.io/ build.

<pluginRepositories>
    <pluginRepository>
        <id>jitpack.io</id>
        <url>https://jitpack.io</url>
    </pluginRepository>
</pluginRepositories>

<plugin>
    <groupId>com.github.dermot-hardy</groupId>
    <artifactId>exec-maven-plugin</artifactId>
    <version>master-SNAPSHOT</version>
</plugin>

This should tie me over for now until your fix gets merged and released. Thank you.

This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.tukaani:xz](https://tukaani.org/xz/java.html) ([source](https://github.com/tukaani-project/xz-java)) | compile | minor | `1.9` -> `1.10` | | [org.eclipse:yasson](https://projects.eclipse.org/projects/ee4j.yasson) ([source](https://github.com/eclipse-ee4j/yasson)) | compile | patch | `3.0.3` -> `3.0.4` | | [org.eclipse.parsson:parsson](https://github.com/eclipse-ee4j/parsson) | compile | patch | `1.1.6` -> `1.1.7` | | [com.uber.nullaway:nullaway](https://github.com/uber/NullAway) | | patch | `0.11.0` -> `0.11.1` | | [io.hosuaby:inject-resources-junit-jupiter](https://github.com/hosuaby/inject-resources) | test | patch | `0.3.3` -> `0.3.5` | | [org.codehaus.mojo:exec-maven-plugin](https://www.mojohaus.org/exec-maven-plugin) ([source](https://github.com/mojohaus/exec-maven-plugin)) | build | minor | `3.3.0` -> `3.4.0` | --- ### Release Notes <details> <summary>tukaani-project/xz-java</summary> ### [`v1.10`](https://github.com/tukaani-project/xz-java/releases/tag/v1.10): XZ for Java 1.10 [Compare Source](tukaani-project/xz-java@v1.9...v1.10) </details> <details> <summary>eclipse-ee4j/yasson</summary> ### [`v3.0.4`](eclipse-ee4j/yasson@3.0.3...3.0.4) [Compare Source](eclipse-ee4j/yasson@3.0.3...3.0.4) </details> <details> <summary>eclipse-ee4j/parsson</summary> ### [`v1.1.7`](eclipse-ee4j/parsson@1.1.6...1.1.7) [Compare Source](eclipse-ee4j/parsson@1.1.6...1.1.7) </details> <details> <summary>uber/NullAway</summary> ### [`v0.11.1`](https://github.com/uber/NullAway/blob/HEAD/CHANGELOG.md#Version-0111) [Compare Source](uber/NullAway@v0.11.0...v0.11.1) - Fix issue 1008 ([#1009](uber/NullAway#1009)) - JSpecify: read upper bound annotations from bytecode and add tests ([#1004](uber/NullAway#1004)) - Fix crash with suggested suppressions in JSpecify mode ([#1001](uber/NullAway#1001)) - Update to JSpecify 1.0 and use JSpecify annotations in NullAway code ([#1000](uber/NullAway#1000)) - Expose [@EnsuresNonNull](https://github.com/EnsuresNonNull) and [@RequiresNonNull](https://github.com/RequiresNonNull) in annotations package ([#999](uber/NullAway#999)) - Don't report initializer warnings on [@NullUnmarked](https://github.com/NullUnmarked) constructors / methods ([#997](uber/NullAway#997)) - Strip annotations from MethodSymbol strings ([#993](uber/NullAway#993)) - JSpecify: fix crashes where declared parameter / return types were raw ([#989](uber/NullAway#989)) - JSpecify: Handle [@nullable](https://github.com/nullable) elements for enhanced-for-loops on arrays ([#986](uber/NullAway#986)) - Features/944 tidy stream nullability propagator ([#985](uber/NullAway#985)) - Tests for loops over arrays ([#982](uber/NullAway#982)) - Bug fixes for array subtyping at returns / parameter passing ([#980](uber/NullAway#980)) - JSpecify: Handle [@nonnull](https://github.com/nonnull) elements in [@nullable](https://github.com/nullable) content arrays ([#963](uber/NullAway#963)) - Don't report [@nullable](https://github.com/nullable) type argument errors for unmarked classes ([#958](uber/NullAway#958)) - External Library Models: Adding support for Nullable upper bounds of Generic Type parameters ([#949](uber/NullAway#949)) - Refactoring / code cleanups: - Test on JDK 22 ([#992](uber/NullAway#992)) - Add test case for [@nullable](https://github.com/nullable) Void with override in JSpecify mode ([#990](uber/NullAway#990)) - Enable UnnecessaryFinal and PreferredInterfaceType EP checks ([#991](uber/NullAway#991)) - Add missing [@test](https://github.com/test) annotation ([#988](uber/NullAway#988)) - Fix typo in variable name ([#987](uber/NullAway#987)) - Remove AbstractConfig class ([#974](uber/NullAway#974)) - Fix Javadoc for MethodRef ([#973](uber/NullAway#973)) - Refactored data clumps with the help of LLMs (research project) ([#960](uber/NullAway#960)) - Build / CI tooling maintenance: - Various cleanups enabled by bumping minimum Java and Error Prone versions ([#962](uber/NullAway#962)) - Disable publishing of snapshot builds from CI ([#967](uber/NullAway#967)) - Update Gradle action usage in CI workflow ([#969](uber/NullAway#969)) - Update Gradle config to always compile Java code using JDK 17 ([#971](uber/NullAway#971)) - Update JavaParser to 3.26.0 ([#970](uber/NullAway#970)) - Reenable JMH benchmarking in a safer manner ([#975](uber/NullAway#975)) - Updated JMH Benchmark Comment Action ([#976](uber/NullAway#976)) - Update to Gradle 8.8 ([#981](uber/NullAway#981)) - Update to Error Prone 2.28.0 ([#984](uber/NullAway#984)) - Update to Gradle 8.9 ([#998](uber/NullAway#998)) - Update to WALA 1.6.6 ([#1003](uber/NullAway#1003)) </details> <details> <summary>hosuaby/inject-resources</summary> ### [`v0.3.5`](hosuaby/inject-resources@v0.3.4...v0.3.5) [Compare Source](hosuaby/inject-resources@v0.3.4...v0.3.5) ### [`v0.3.4`](hosuaby/inject-resources@v0.3.3...v0.3.4) [Compare Source](hosuaby/inject-resources@v0.3.3...v0.3.4) </details> <details> <summary>mojohaus/exec-maven-plugin</summary> ### [`v3.4.0`](https://github.com/mojohaus/exec-maven-plugin/releases/tag/3.4.0) [Compare Source](mojohaus/exec-maven-plugin@3.3.0...3.4.0)  #### 🚀 New features and improvements - Allow `<includePluginDependencies>` to be specified for the exec:exec goal ([#432](mojohaus/exec-maven-plugin#432)) [@sebthom](https://github.com/sebthom) #### 🐛 Bug Fixes - Do not get UPPERCASE env vars ([#427](mojohaus/exec-maven-plugin#427)) [@wheezil](https://github.com/wheezil) #### 📦 Dependency updates - Bump org.codehaus.mojo:mojo-parent from 82 to 84 ([#434](mojohaus/exec-maven-plugin#434)) [@dependabot](https://github.com/dependabot) - Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 3.0.1 ([#431](mojohaus/exec-maven-plugin#431)) [@dependabot](https://github.com/dependabot) #### 👻 Maintenance - Remove Log4j 1.2.x from ITs ([#437](mojohaus/exec-maven-plugin#437)) [@slawekjaranowski](https://github.com/slawekjaranowski) #### 🔧 Build - Use Maven 3.9.7 and 4.0.0-beta-3 ([#433](mojohaus/exec-maven-plugin#433)) [@slawekjaranowski](https://github.com/slawekjaranowski) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Do not get UPPERCASE env vars

ec3679c

wheezil mentioned this pull request May 10, 2024

MSBuild should sanitize environment block on startup dotnet/msbuild#5726

Closed

slawekjaranowski reviewed May 10, 2024

View reviewed changes

src/main/java/org/codehaus/mojo/exec/ExecMojo.java Outdated Show resolved Hide resolved

slawekjaranowski linked an issue May 11, 2024 that may be closed by this pull request

Non-Uppercase Environment Variables duplicated with an Uppercase version #328

Closed

slawekjaranowski added the bug label May 11, 2024

PR feedback: use System.getenv()

6eb95e5

slawekjaranowski reviewed May 13, 2024

View reviewed changes

src/main/java/org/codehaus/mojo/exec/ExecMojo.java Outdated Show resolved Hide resolved

John Lilley added 3 commits June 25, 2024 01:47

Copy immutable env map

6b5f3e2

Merge remote-tracking branch 'upstream/master'

182c829

Making sure that my fork is up to date

remove unused import

0731ed3

slawekjaranowski self-assigned this Jul 16, 2024

slawekjaranowski approved these changes Aug 5, 2024

View reviewed changes

slawekjaranowski merged commit 881bb9c into mojohaus:master Aug 5, 2024

DarkDrek mentioned this pull request Aug 7, 2024

3.4.0 can't find executable in Path environment variable on Windows #438

Closed

Conversation

wheezil commented May 10, 2024

Uh oh!

Uh oh!

wheezil commented May 12, 2024

Uh oh!

Uh oh!

slawekjaranowski commented May 13, 2024

Uh oh!

slawekjaranowski commented May 13, 2024

Uh oh!

slawekjaranowski commented May 13, 2024

Uh oh!

slawekjaranowski commented May 21, 2024

Uh oh!

wheezil commented May 21, 2024 via email

Uh oh!

wheezil commented Jul 3, 2024

Uh oh!

dermot-hardy commented Jul 15, 2024

Uh oh!

wheezil commented Jul 15, 2024

Uh oh!

dermot-hardy commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wheezil commented Jul 15, 2024

Uh oh!

dermot-hardy commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dermot-hardy commented Jul 15, 2024 •

edited

Loading

dermot-hardy commented Jul 15, 2024 •

edited

Loading