fix(utils): align package.json entrypoints with rslib output#4436
Closed
bigslycat wants to merge 2 commits intomodule-federation:mainfrom
Closed
fix(utils): align package.json entrypoints with rslib output#4436bigslycat wants to merge 2 commits intomodule-federation:mainfrom
bigslycat wants to merge 2 commits intomodule-federation:mainfrom
Conversation
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
@bigslycat please add changeset |
Contributor
Bundle Size Report1 package(s) changed, 37 unchanged.
Total dist: 6.66 MB (no change) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes broken entrypoints for
@module-federation/utilities@3.1.84.After the rslib bundleless migration (commit bd276ac / PR #4357), the build output moved to nested folders (
dist/esm,dist/cjs,dist/types), butpackages/utilities/package.jsonstill referenced the old flatdist/index.*files, making the package non-resolvable for consumers.What changed
Align
packages/utilities/package.jsonentry fields with the current rslib output layout:main:./dist/cjs/index.jsmodule:./dist/esm/index.mjstypes:./dist/types/index.d.tsexports["."]+typesVersions["*"]["."]: updated accordinglyHow to verify
Minimal consumer repro (same as the linked issue):
npm i @module-federation/utilities@3.1.84 node -e "console.log(require.resolve('@module-federation/utilities'))"Expected: resolves successfully (no "Cannot find module …/dist/index.*" errors).
Repo-side sanity check (optional):
pnpm -w nx run utils:build # ensure dist/esm, dist/cjs, dist/types are produced and package entrypoints matchRelated Issue
Fixes #4434.
Regression introduced by bd276ac / #4357.
Types of changes
Checklist