Skip to content

fix(modernjs)!: ship .mjs files for correct ESM output#4240

Merged
2heal1 merged 1 commit intomodule-federation:mainfrom
fi3ework:modernjs-mjs
Dec 2, 2025
Merged

fix(modernjs)!: ship .mjs files for correct ESM output#4240
2heal1 merged 1 commit intomodule-federation:mainfrom
fi3ework:modernjs-mjs

Conversation

@fi3ework
Copy link
Copy Markdown
Contributor

@fi3ework fi3ework commented Nov 24, 2025

Description

change build tool to Rslib so the output ESM code can be appended with .mjs automatically. the previous ESM output is not correct so Storybook v10 can't using import() to load it.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 24, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 38ec285

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@module-federation/modern-js Major
@module-federation/runtime Major
@module-federation/enhanced Major
@module-federation/rspack Major
@module-federation/webpack-bundler-runtime Major
@module-federation/sdk Major
@module-federation/runtime-tools Major
@module-federation/managers Major
@module-federation/manifest Major
@module-federation/dts-plugin Major
@module-federation/third-party-dts-extractor Major
@module-federation/devtools Major
@module-federation/bridge-react Major
@module-federation/bridge-vue3 Major
@module-federation/bridge-shared Major
@module-federation/bridge-react-webpack-plugin Major
@module-federation/retry-plugin Major
@module-federation/data-prefetch Major
@module-federation/rsbuild-plugin Major
@module-federation/error-codes Major
@module-federation/inject-external-runtime-core-plugin Major
@module-federation/runtime-core Major
create-module-federation Major
@module-federation/cli Major
@module-federation/rspress-plugin Major
@module-federation/metro Major
@module-federation/metro-plugin-rnef Major
@module-federation/metro-plugin-rnc-cli Major
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/storybook-addon Major
@module-federation/modernjsapp Patch
@module-federation/esbuild Patch
@module-federation/utilities Patch
remote5 Patch
remote6 Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 24, 2025 •
edited
Loading

✅ Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 38ec285
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/69251ac6a0cd3e00081f3409
😎 Deploy Preview https://deploy-preview-4240--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fi3ework
Copy link
Copy Markdown
Contributor Author

fi3ework commented Nov 26, 2025

@2heal1 PTAL.

@2heal1 2heal1 merged commit 90c6a40 into module-federation:main Dec 2, 2025
18 checks passed
2heal1 added a commit that referenced this pull request Dec 8, 2025
@2heal1
feat: finish basic implementation
8f26d8b 
chore: add ut

feat: done

fix(modernjs)!: ship .mjs files for correct ESM output (#4240)

fix: prefer use `stroybook/internal/node-logger` as logger (#4235)

docs: remove invalid lark link (#4253)

fix: manifest type
@2heal1 2heal1 mentioned this pull request Dec 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2heal1 2heal1 2heal1 approved these changes

Assignees

No one assigned

Labels

change: fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fi3ework @2heal1