Add support for dependency exclusion#170
Merged
aalmiray merged 1 commit intomoditect:mainfrom Mar 2, 2023
Merged
Conversation
gunnarmorling
approved these changes
Jul 28, 2022
Member
gunnarmorling
left a comment
There was a problem hiding this comment.
LGTM; could you only add the new option to the description in the README, so folks know what it does? Sorry btw. for the long delay, somehow missed the notifications here.
Contributor
Author
|
Sure, let me do that and I'll ping you back here. |
aalmiray
reviewed
Mar 2, 2023
|
|
||
|
|
||
| if (exclusions != null) { | ||
| ArtifactFilter scopeFilter = new ScopeArtifactFilter("compile+runtime"); |
Contributor
There was a problem hiding this comment.
Revisit this as technically provided scope could map to requires static instructions in the module descriptor.
Contributor
|
I'll take care of the readme updates |
aalmiray
added a commit
to aalmiray/moditect
that referenced
this pull request
Mar 2, 2023
aalmiray
added a commit
that referenced
this pull request
Mar 2, 2023
|
Released in 1.0.0.RC3 -> https://github.com/moditect/moditect/releases/tag/1.0.0.RC3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169