Skip to content

fix: v2 follow-up improvements#1318

Merged
KKonstantinov merged 2 commits intomainfrom
fweinberger/v2-followups
Dec 19, 2025
Merged

fix: v2 follow-up improvements#1318
KKonstantinov merged 2 commits intomainfrom
fweinberger/v2-followups

Conversation

@felixweinberger
Copy link
Contributor

@felixweinberger felixweinberger commented Dec 19, 2025 •
edited
Loading

Follow-up improvements after the v2 monorepo merge.

Changes

  • Add v2 development notice at top of README
  • Fix npm badge URLs (add missing %2F encoding)
  • Update CONTRIBUTING.md for pnpm/corepack workflow
  • Document branch strategy (main vs v1.x)
  • Add base branch guidance for contributors
  • Don't export InMemoryEventStore in public API

Motivation and Context

These are follow-up items noted during the v2 PR review to improve documentation and clean up the public API.

Types of changes

  • Documentation update
  • Bug fix (npm badge URLs)

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally

@felixweinberger
docs: v2 follow-up improvements
81a8288 
- Add v2 development notice at top of README
- Fix npm badge URLs (add missing %2F encoding)
- Update CONTRIBUTING.md for pnpm/corepack workflow
- Document branch strategy (main vs v1.x)
- Move InMemoryEventStore from server exports to test-helpers
@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ea36d69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 19, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/client@1318

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/server@1318

commit: ea36d69

@felixweinberger felixweinberger force-pushed the fweinberger/v2-followups branch from 79f9f46 to c74af26 Compare December 19, 2025 13:44
@felixweinberger felixweinberger changed the title docs: v2 follow-up improvements fix: v2 follow-up improvements Dec 19, 2025
@felixweinberger felixweinberger force-pushed the fweinberger/v2-followups branch 2 times, most recently from 9117188 to 90fbcd9 Compare December 19, 2025 13:50
felixweinberger
felixweinberger commented Dec 19, 2025
View reviewed changes
test/integration/test/taskResumability.test.ts
/**
* Simple in-memory EventStore for testing resumability.
*/
class InMemoryEventStore implements EventStore {
Copy link
Contributor Author

@felixweinberger felixweinberger Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a test only EventStore instead of promoting it to public

@felixweinberger felixweinberger force-pushed the fweinberger/v2-followups branch 4 times, most recently from 91fc61d to 5648a2a Compare December 19, 2025 14:03
@felixweinberger
docs: v2 follow-up improvements
ea36d69 
- Add v2 development notice at top of README
- Fix npm badge URLs (add missing %2F encoding)
- Update CONTRIBUTING.md for pnpm/corepack workflow
- Document branch strategy (main vs v1.x)
- Remove InMemoryEventStore from server exports (inline in test instead)
@felixweinberger felixweinberger force-pushed the fweinberger/v2-followups branch from 5648a2a to ea36d69 Compare December 19, 2025 14:04
@felixweinberger felixweinberger marked this pull request as ready for review December 19, 2025 14:24
@felixweinberger felixweinberger requested a review from a team as a code owner December 19, 2025 14:24
@KKonstantinov KKonstantinov merged commit 8a1b457 into main Dec 19, 2025
11 checks passed
@KKonstantinov KKonstantinov deleted the fweinberger/v2-followups branch December 19, 2025 14:46
shellRaining pushed a commit to shellRaining/typescript-sdk that referenced this pull request Dec 20, 2025
@felixweinberger @shellRaining
fix: v2 follow-up improvements (modelcontextprotocol#1318)
9e7f4ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KKonstantinov KKonstantinov KKonstantinov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@felixweinberger @KKonstantinov