Skip to content

Vecdeque CVE demo#971

Merged
celinval merged 10 commits intomodel-checking:mainfrom
celinval:vecdeque-cve-demo
Apr 2, 2022
Merged

Vecdeque CVE demo#971
celinval merged 10 commits intomodel-checking:mainfrom
celinval:vecdeque-cve-demo

Conversation

@celinval
Copy link
Contributor

@celinval celinval commented Mar 22, 2022

Description of changes:

Adding harnesses for VecDeque CVE.

Resolved issues:

Fixes #910

Call-outs:

Testing:

  • How is this change tested?

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@celinval celinval requested a review from a team as a code owner March 22, 2022 07:39
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mark this as the problematic line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could be more specific and say this is from nightly-2017-09-23

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually from a newer version of vec_deque that I inserted the issue. I can rollback to the one from nightly-2017-09-23 if you prefer. Let me know what you think.

@nchong-at-aws
Copy link
Contributor

Also, resolves #910

@celinval celinval force-pushed the vecdeque-cve-demo branch from 60475f5 to 8fb6c90 Compare March 29, 2022 21:34
@celinval celinval merged commit 5b5133f into model-checking:main Apr 2, 2022
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 26, 2022

* Add harness to VecDeque CVE
tedinski pushed a commit that referenced this pull request Apr 27, 2022

* Add harness to VecDeque CVE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Rust Standard Library example to regression

2 participants