Merged
Conversation
zhassan-aws
reviewed
Mar 8, 2022
src/cargo-kani/src/args_toml.rs
Outdated
| /// `cargo locate-project` produces a response like: | ||
| /// `{"root":"/full/path/to/src/cargo-kani/Cargo.toml"}` | ||
| fn cargo_locate_project() -> Result<PathBuf> { | ||
| let cmd = Command::new("cargo").arg("locate-project").output()?; |
Contributor
There was a problem hiding this comment.
One option is to run cargo locate-project with --message-format plain to avoid parsing json.
$ pwd
/home/ubuntu/git/kani/tests/cargo-kani/config/src
$ cargo locate-project
{"root":"/home/ubuntu/git/kani/tests/cargo-kani/config/Cargo.toml"}
$ cargo locate-project --message-format plain
/home/ubuntu/git/kani/tests/cargo-kani/config/Cargo.toml
Contributor
Author
There was a problem hiding this comment.
Done, though while debugging why everything suddenly failed (there is a newline in the bytes, oh), I realized I should update a bit of the error handling here too.
zhassan-aws
approved these changes
Mar 9, 2022
tedinski
added a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* use message-format plain, update error handling
tedinski
added a commit
that referenced
this pull request
Apr 27, 2022
* use message-format plain, update error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
While bumbling around trying to find the name of "this crate" I basically implemented this, so I've cleaned this up to submit separately from anything else.
Resolved issues:
Resolves #717
Call-outs:
Contains a few extra cleanups and comments unrelated to headline feature.
Testing:
How is this change tested? existing suite. Notably not really feasible to add to our cargo-kani test suite since the way all those invocations work specifies the working directory. But it does work now to e.g. call
cargo-kanifromsrcIs this a refactor change? basically yes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.