Partial support for bitreverse#779
Merged
celinval merged 4 commits intomodel-checking:mainfrom Jan 27, 2022
Merged
Conversation
celinval
suggested changes
Jan 26, 2022
Contributor
celinval
left a comment
There was a problem hiding this comment.
Can you please describe what partial support means here? From the user perspective, what has changed with this PR?
Contributor
Author
Right, it would be best to claim support in the work for #778 and leave the current support value as it was. What do you think? |
911f70e to
ed05de3
Compare
ed05de3 to
93a263d
Compare
Contributor
Author
|
Dropped the change on the table and sync'd with |
This was referenced Mar 15, 2022
Closed
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Support for `bitreverse` (WIP) * Add test for all types
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Support for `bitreverse` (WIP) * Add test for all types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds partial support for the
bitreverseintrinsic.It is supposed to work until support is added in CBMC, but created #778 for tracking and doing the remaining work then.
Resolved issues:
Resolves #745
Opens #778
Call-outs:
Testing:
How is this change tested? Regression + new "fixme" test.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.