Move compiletest out of x.py#753
Merged
adpaco-aws merged 4 commits intomodel-checking:mainfrom Jan 18, 2022
Merged
Conversation
celinval
approved these changes
Jan 13, 2022
Contributor
celinval
left a comment
There was a problem hiding this comment.
That's awesome! \o/\o/
Maybe we can pull this out later and put it in its own script that takes one or more test suite name as an argument and executes them.
62e0253 to
26ef8b0
Compare
Contributor
Author
044e9ba to
d5fb058
Compare
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Move compiletest out of `x.py` * Fixups * Add `pwd` to `--build-base` and split cmd into several lines * Use correct mode for `rmc-docs` suite
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Moves
compiletestout ofx.pyCall-outs:
Testing:
How is this change tested? Existing regression.
Is this a refactor change? Yes.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.