Better explanations and extra functionality in MutableBody#3382
Merged
artemagvanian merged 7 commits intomodel-checking:mainfrom Jul 25, 2024
Merged
Better explanations and extra functionality in MutableBody#3382artemagvanian merged 7 commits intomodel-checking:mainfrom
MutableBody#3382artemagvanian merged 7 commits intomodel-checking:mainfrom
Conversation
celinval
reviewed
Jul 25, 2024
Contributor
celinval
left a comment
There was a problem hiding this comment.
It looks good. Thanks for improving documentation.
celinval
reviewed
Jul 25, 2024
tautschnig
added a commit
to tautschnig/kani
that referenced
this pull request
Aug 5, 2024
* Remove `gen_function_local_variable` and `initializer_fn_name`, the last uses of both of which were removed in model-checking#3305. * Remove `arg_count`, which was introduced in model-checking#3363, but not actually used. * Remove `insert_bb`, which was introduced in model-checking#3382, but not actually used. The toolchain upgrade to 2024-08-04 includes several bugfixes to dead-code analysis in rustc, explaining why we the recent PRs as listed above weren't flagged before for introducing dead code. Resolves: model-checking#3411
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
* Remove `gen_function_local_variable` and `initializer_fn_name`, the last uses of both of which were removed in #3305. * Mark `arg_count`, which was introduced in #3363, as `allow(dead_code)` as it will soon be used. * Mark `insert_bb`, which was introduced in #3382, as `allow(dead_code)` as it will soon be used. The toolchain upgrade to 2024-08-04 includes several bugfixes to dead-code analysis in rustc, explaining why we the recent PRs as listed above weren't flagged before for introducing dead code. Resolves: #3411 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MutableBodyis the core data structure for MIR manipulation in instrumentation passes. However, its public methods have limited documentation and unclear semantics. This slowed down the development of instrumentation passes.This PR aims to fix that by:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.