Merged
Conversation
celinval
reviewed
Apr 25, 2022
Contributor
celinval
left a comment
There was a problem hiding this comment.
Can you please add a bit more test coverage to transmute? Things like transmute pointers, structures, slices? Thanks
| let arg_align_check = self.codegen_assert( | ||
| arg_align, | ||
| PropertyClass::DefaultAssertion, | ||
| "transmute: argument type is properly aligned", |
Contributor
There was a problem hiding this comment.
nit: The failure message usually states the failure. Maybe change it to something like: transmute check: argument type isn't properly aligned or transmute check: argument type must be properly aligned
Contributor
Author
|
I have restored the original implementation and added 4 tests to check correct transmutations between
This is in addition to another one that is present in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updates the
transmuteintrinsic with alignment checks for both the argument type and the result type. However, this does not seem to be working as I expected, and a large number of failures are being triggered on our regression.In fact, the test added in this PR is failing with "transmute: result type is properly aligned" instead of "transmute: argument type is properly aligned". I don't know if I'm missing something.
Resolved issues:
Part of #727
Call-outs:
Testing:
How is this change tested? Adds one test.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.