Disable rounding intrinsics#1026
Merged
adpaco-aws merged 2 commits intomodel-checking:mainfrom Apr 8, 2022
Merged
Conversation
zhassan-aws
approved these changes
Apr 8, 2022
Contributor
zhassan-aws
left a comment
There was a problem hiding this comment.
Disabling them until they're fixed sounds like the right thing to me. Should we replace their implementations with:
codegen_unimplemented_intrinsic!(
"https://github.com/model-checking/kani/issues/1025"
though?
f0861ac to
9a2a3fc
Compare
Contributor
Author
Yes, thanks! It's done. |
This was referenced Apr 8, 2022
Closed
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Disable rounding intrinsics * Use `codegen_unimplemented_intrinsic`
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Disable rounding intrinsics * Use `codegen_unimplemented_intrinsic`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Disables rounding intrinsics which appear to be replaced by assert-false statements for some reason (debugging will come later). We could leave them "as is", but in my opinion we should control how they behave for now and only enable them when they are fixed and tested.
Resolved issues:
Part of #727
Call-outs:
Testing:
How is this change tested? Adds 6 negative tests.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.