Skip to content

Refactor CI action#1024

Merged
tedinski merged 4 commits intomodel-checking:mainfrom
tedinski:refactor-ci
Apr 8, 2022
Merged

Refactor CI action#1024
tedinski merged 4 commits intomodel-checking:mainfrom
tedinski:refactor-ci

Conversation

@tedinski
Copy link
Contributor

@tedinski tedinski commented Apr 7, 2022

Description of changes:

This separates "setup" from "build", in preparation for a new workflow that will test out the release build/bundle. This should be a pure refactor in the workflow, no behavior changes.

Resolved issues:

Call-outs:

  1. Oof, only just noticed the python version requirement. Will investigate/ask if this can be fixed...

Testing:

  • How is this change tested?

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@tedinski tedinski requested a review from a team as a code owner April 7, 2022 22:21
Copy link
Contributor

@adpaco-aws adpaco-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check if it's possible to use a lower Python version in the future.

@tedinski tedinski merged commit ad55804 into model-checking:main Apr 8, 2022
@tedinski tedinski deleted the refactor-ci branch April 8, 2022 15:45
tedinski added a commit to tedinski/rmc that referenced this pull request Apr 26, 2022
* This separates "setup" from "build"
tedinski added a commit that referenced this pull request Apr 27, 2022
* This separates "setup" from "build"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants