Add a test for discriminant_value#1021
Merged
adpaco-aws merged 2 commits intomodel-checking:mainfrom Apr 7, 2022
Merged
Conversation
celinval
approved these changes
Apr 7, 2022
Contributor
celinval
left a comment
There was a problem hiding this comment.
Nice coverage! Please address the comment below before pushing.
| } | ||
|
|
||
| #[kani::proof] | ||
| fn main() { |
Contributor
There was a problem hiding this comment.
Can you please split this into 3 different harnesses? I think it will make this much easier to read.
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion, I didn't think about that! It's now split into 4 harnesses, can you take another look?
celinval
approved these changes
Apr 7, 2022
Contributor
celinval
left a comment
There was a problem hiding this comment.
Looks good to me. Maybe next time use /// to comment the harness instead of the function body. But that is just a test so no need to bother. Thanks!
Closed
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Add a test for `discriminant_value` * Split into 4 proofs
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Add a test for `discriminant_value` * Split into 4 proofs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a test for
discriminant_value. The implementation works as expected for all covered cases, so this completes the audit for the intrinsic.Resolved issues:
Part of #727
Call-outs:
Testing:
How is this change tested? Adds one test.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.