Skip to content

Minor updates in README for readability.#1018

Merged
jaisnan merged 7 commits intomodel-checking:mainfrom
jaisnan:update-readme-visual
Apr 6, 2022
Merged

Minor updates in README for readability.#1018
jaisnan merged 7 commits intomodel-checking:mainfrom
jaisnan:update-readme-visual

Conversation

@jaisnan
Copy link
Contributor

@jaisnan jaisnan commented Apr 6, 2022

Description of changes:

The current README has some text and code that's difficult to read. This change adds some spacing and some capitalizing.

Before -

image

After -

image

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@jaisnan jaisnan requested a review from a team as a code owner April 6, 2022 19:05
README.md Outdated
Comment on lines +6 to +9
* Memory Safety -- even in unsafe rust code.
* User specified assertions.
* Absence of panics.
* Checks for some classes of undefined behavior.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case it's helpful, the rule I followed to write this is the second case in https://www.dailywritingtips.com/bulleted-lists/

I'm okay with first letters being capitalized, but I don't think we should keep the dots. Also, Rust is a name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the link, I'll use it here on. I think keeping the first letters capitalized makes it easier to read. I'll remove the dots add Rust as a name.

README.md Outdated

#[kani::proof]
fn check_my_property() {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree lines between these help, but I would remove this first one (most of the time, programs have a comment or declaration here).

README.md Outdated
* Memory Safety -- even in unsafe Rust code
* User specified assertions
* Absence of panics
* Checks for some classes of undefined behavior
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also change this to "Absence of some classes of undefined behavior", since the sentence is "Kani verifies ..." which does not fit with "Check for some classes ...".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tedinski @adpaco-aws thoughts?

I personally agree with the suggestion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the way I understood this sentence is that Kani verifies the checks for those classes (here "checks" could be a noun or verb). But it may be better to rephrase just in case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that could be a bit confusing to first time readers

Copy link
Contributor

@adpaco-aws adpaco-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a minor correction.

README.md Outdated
* absence of panics
* checks for some classes of undefined behavior
* Memory Safety -- even in unsafe Rust code
* User specified assertions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* User specified assertions
* User-specified assertions

@jaisnan jaisnan merged commit be6d5cc into model-checking:main Apr 6, 2022
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 26, 2022
tedinski pushed a commit that referenced this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants