Skip to content

Documentation: Uniform style#1016

Merged
adpaco-aws merged 8 commits intomodel-checking:mainfrom
adpaco-aws:doc-review-uniform
Apr 6, 2022
Merged

Documentation: Uniform style#1016
adpaco-aws merged 8 commits intomodel-checking:mainfrom
adpaco-aws:doc-review-uniform

Conversation

@adpaco-aws
Copy link
Contributor

@adpaco-aws adpaco-aws commented Apr 5, 2022

Description of changes:

Makes a series of changes so that the documentation shows a uniform style:

  • Use more contractions.
  • Use **NOTE**: for all notes/warnings.
  • Use "code available here" or just "available here" for links to example files.
  • Use <directory> as labels for links to directories.
  • Remove "The" from the title of SUMMARY.md - now "Kani Rust Verifier"

Resolved issues:

Resolves #700

Call-outs:

Testing:

  • How is this change tested? N/A

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner April 5, 2022 22:22
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to make notes and links to code consistent look good to me. I'm not sure about the contractions though. In fact, I'm a bit opposed to getting rid of them, as they make the document a bit too formal. The Rust book as well as standard library documentation uses contractions, so I think we should keep them.

@adpaco-aws adpaco-aws force-pushed the doc-review-uniform branch from 8cb049d to 1a4c784 Compare April 6, 2022 18:23
@adpaco-aws
Copy link
Contributor Author

That's fair, I did not realize contractions were being used there.

The changes are now split into several commits. The last ones add more contractions, except in cases were "not" was being contracted (these look a little forced sometimes). We can drop them if you want to keep the text as is.

@adpaco-aws adpaco-aws requested a review from zhassan-aws April 6, 2022 18:49
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with the extra contractions, except for the two that I pointed out.

@adpaco-aws adpaco-aws force-pushed the doc-review-uniform branch from 0b6c894 to a583cb0 Compare April 6, 2022 19:47
@adpaco-aws adpaco-aws merged commit 0e37961 into model-checking:main Apr 6, 2022
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 26, 2022
* Remove "The" in documentation title

* Use `**NOTE**:` for all notes

* Use "code available here" for links to example files.

* Use `<directory>` as labels for links to directories

* Use more contractions
tedinski pushed a commit that referenced this pull request Apr 27, 2022
* Remove "The" in documentation title

* Use `**NOTE**:` for all notes

* Use "code available here" for links to example files.

* Use `<directory>` as labels for links to directories

* Use more contractions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In-depth review of general documentation

2 participants