Fix decodeURI process crash#712
Merged
255kb merged 3 commits intomockoon:fix/689-decode-uri-transactionfrom May 30, 2022
Merged
Fix decodeURI process crash#712255kb merged 3 commits intomockoon:fix/689-decode-uri-transactionfrom
255kb merged 3 commits intomockoon:fix/689-decode-uri-transactionfrom
Conversation
255kb
requested changes
May 20, 2022
Member
255kb
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
I added one remark/change request.
Also, could you please format using Prettier?
Thank you
Member
|
@tsgodara I will merge this and make the changes as I am going to finalize a new release in the coming days. |
255kb
pushed a commit
that referenced
this pull request
May 30, 2022
* Fix decodeURI process crash (#712) * Fix DecodeURI process crashing * 689: Fix DecodeURI process crashing * 689: Fixed lint error Co-authored-by: Tapendra Godara <tapen@Tapendras-MacBook-Pro.local> * Remove console.log and maintain raw query display in logs tab There is no real need to log as this transaction query is the raw version displayed in the log tabs only. A failure wouldn't impact the application in any way. Co-authored-by: Tapendra S Godara <tsgodara@gmail.com> Co-authored-by: Tapendra Godara <tapen@Tapendras-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #689
Technical implementation details
Checklist