Fix wrong region displayed during re-deploy#1983
Merged
Conversation
Race condition was displaying preferred region instead of the redeployed instance region Closes #1982
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition that was causing the wrong region to be displayed when redeploying an existing instance. The issue occurred because observables were executing independently, allowing the user's preferred region to override the existing instance's actual region.
Key Changes:
- Synchronized form population using
combineLatestto ensure existing instance data takes precedence over user preferences - Refactored initialization logic from
ngOnInitto constructor for better control flow - Removed unused imports and simplified observable chains
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Race condition was displaying preferred region instead of the redeployed instance region Closes #1982
Technical implementation details
Checklist
Closes #{issue_number}