Fix port not being displayed in UI if a hostname is provided#1971
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the port number was not displayed in the UI when a custom hostname was provided. The original logic would show either the hostname (without port) OR localhost:port, but never hostname:port.
Key Changes
- Fixed the
buildApiUrlfunction to always append the port to the hostname, defaulting to 'localhost' when no hostname is provided - Migrated Angular template syntax from
*ngIf/*ngForto the newer@if/@forcontrol flow syntax in environment-settings component - Changed
onMessagemethod visibility fromprivatetoprotectedin auth-iframe-modal component (best practice for@HostListenerdecorated methods)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/app/src/renderer/app/libs/utils.lib.ts | Fixed URL construction to always include port with hostname |
| packages/app/src/renderer/app/components/modals/auth-iframe-modal/auth-iframe-modal.component.ts | Updated method visibility modifier from private to protected for @HostListener method |
| packages/app/src/renderer/app/components/environment-settings/environment-settings.component.ts | Removed unused NgIf import after template migration |
| packages/app/src/renderer/app/components/environment-settings/environment-settings.component.html | Migrated from *ngIf to @if control flow syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1910
Technical implementation details
Checklist
Closes #{issue_number}