networking: Decentralized port allocation.#543
Merged
aluzzardi merged 1 commit intomoby:masterfrom May 6, 2016
Merged
Conversation
This change moves port allocation from the allocator to the engine. Related to #485 Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
e544035 to
4ace89b
Compare
Current coverage is 42.92%
@@ master #543 diff @@
==========================================
Files 64 20 -44
Lines 8767 2400 -6367
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 4817 1030 -3787
+ Misses 3248 1217 -2031
+ Partials 702 153 -549
|
Contributor
|
LGTM |
Contributor
|
I think the followup PR to get the actual port state from agent should probably be done on top of my pending PR #538 which will separate out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves port allocation from the allocator to the engine.
It's a first step - we then need to work on reporting those allocated ports by adding a
ContainerStatustoTaskStatuswhich would embed arepeated PortConfig allocated_ports. That work will come as a follow up PR./cc @mrjana @stevvooe
Related to #485