Add Container to hold container specific task data#538
Merged
aaronlehmann merged 1 commit intomoby:masterfrom May 11, 2016
mrjana:taskapi
Merged
Add Container to hold container specific task data#538aaronlehmann merged 1 commit intomoby:masterfrom mrjana:taskapi
aaronlehmann merged 1 commit intomoby:masterfrom
mrjana:taskapi
Conversation
agent/exec/container/container.go
Outdated
| type containerConfig struct { | ||
| task *api.Task | ||
| runtime *api.Container // resolved container specification. | ||
| runtime *api.ContainerSpec // resolved container specification. |
Contributor
There was a problem hiding this comment.
We can probably just access this through the task field. Calling this runtime is inaccurate, since it is just the spec now.
Contributor
Author
|
@stevvooe @aluzzardi @aaronlehmann This is ready for review. |
api/objects.proto
Outdated
| // Container contains all runtime state of a task which is container runtime specific. | ||
| message Container { | ||
| // Spec defines the container specific configuration for this container. | ||
| ContainerSpec spec = 1; |
Collaborator
There was a problem hiding this comment.
I think this should be non-nullable to be consistent with our other fields called spec.
Contributor
|
LGTM I think we can defer most of the feedback, albeit, it looks like there is a merge conflict. |
Right now all container runtime specific task data such as network attachments and endpoint information is directly stored in task. Instead it should inside a container runtime specific message so that we can add other runtimes later without changing the model. Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now all container runtime specific task data such as network
attachments and endpoint information is directly stored in task. Instead
it should inside a container runtime specific message so that we can add
other runtimes later without changing the model.
Fixes #478
/cc @stevvooe
Signed-off-by: Jana Radhakrishnan mrjana@docker.com