csi: remove unused startMockServer and github.com/rexray/gocsi dependency#3184
Merged
dperny merged 1 commit intomoby:masterfrom Oct 17, 2024
Merged
csi: remove unused startMockServer and github.com/rexray/gocsi dependency#3184dperny merged 1 commit intomoby:masterfrom
dperny merged 1 commit intomoby:masterfrom
Conversation
…ency This utility was used in manager/volumes/volumes_test.go, which got deleted in b0a1aa6, making the startMockServer unused. Remove the file, so that we can remove the problematic github.com/rexray/gocsi dependency, which is unmaintained, and required us to use Drew's fork to prevent legacy dependencies from being pulled in through the indirect github.com/coreos/etcd/clientv3 dependency; go: finding module for package github.com/coreos/etcd/clientv3/concurrency go: finding module for package github.com/coreos/etcd/clientv3 go: found github.com/coreos/etcd/clientv3 in github.com/coreos/etcd v3.3.27+incompatible go: found github.com/coreos/etcd/clientv3/concurrency in github.com/coreos/etcd v3.3.27+incompatible go: finding module for package github.com/coreos/go-systemd/journal go: finding module for package github.com/coreos/pkg/capnslog go: found github.com/coreos/pkg/capnslog in github.com/coreos/pkg v0.0.0-20240122114842-bbd7aa9bf6fb go: found github.com/coreos/go-systemd/journal in github.com/coreos/go-systemd v0.0.0-20191104093116-d3cd4ed1dbcf The above resolution resulted in these legacy versions to be added; github.com/coreos/etcd v3.3.27+incompatible // indirect github.com/coreos/go-systemd v0.0.0-20191104093116-d3cd4ed1dbcf // indirect github.com/coreos/pkg v0.0.0-20240122114842-bbd7aa9bf6fb // indirect Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
74cc943 to
2501f6e
Compare
Member
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3184 +/- ##
==========================================
+ Coverage 57.28% 57.46% +0.17%
==========================================
Files 144 144
Lines 30598 30598
==========================================
+ Hits 17528 17582 +54
+ Misses 11732 11678 -54
Partials 1338 1338 |
vvoland
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This utility was used in manager/volumes/volumes_test.go, which got deleted in b0a1aa6 (#3022), making the startMockServer unused.
Remove the file, so that we can remove the problematic github.com/rexray/gocsi dependency, which is unmaintained, and required us to use Drew's fork to prevent legacy dependencies from being pulled in through the indirect github.com/coreos/etcd/clientv3 dependency;
The above resolution resulted in these legacy versions to be added;
- What I did
- How I did it
- How to test it
- Description for the changelog