vendor: go.etcd.io/etcd v3.5.16, go.etcd.io/etcd/server/v3 v3.5.16#48650
Merged
thaJeztah merged 2 commits intomoby:masterfrom Oct 22, 2024
Merged
vendor: go.etcd.io/etcd v3.5.16, go.etcd.io/etcd/server/v3 v3.5.16#48650thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
Member
Author
|
Oh! I think I know; it's that rexray thing again; we don't use a replace here, but swarmkit does; https://github.com/moby/swarmkit/blob/ea1a7cec35cb05dce3cff2de3f4ee28cbca6ca79/go.mod#L94-L95 First time that I opened a PR to remove that dependency as it wasn't even used; |
vvoland
reviewed
Oct 17, 2024
This was referenced Oct 17, 2024
0af717b to
12dbe5f
Compare
This dependency comes from SwarmKit, but didn't update dependencies for quite some time. Update the dependencies to their latest patch release. Keeping the server at v3.5.6, because newer versions pull in some odd dependencies (but not used in code). changelog: https://github.com/etcd-io/etcd/blob/f0187c38d1828a3241984c976a3cd2fd4749afc6/CHANGELOG/CHANGELOG-3.5.md full diff: etcd-io/etcd@v3.5.6...v3.5.16 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This dependency comes from SwarmKit, but didn't update dependencies
for quite some time. Update the dependencies to their latest patch
release.
For some reason, updating this dependency brings back various legacy
versions of dependencies through `github.com/coreos/etcd/clientv3/concurrency`;
go: finding module for package github.com/coreos/etcd/clientv3/concurrency
go: finding module for package github.com/coreos/etcd/clientv3
go: found github.com/coreos/etcd/clientv3 in github.com/coreos/etcd v3.3.27+incompatible
go: found github.com/coreos/etcd/clientv3/concurrency in github.com/coreos/etcd v3.3.27+incompatible
go: finding module for package github.com/coreos/go-systemd/journal
go: finding module for package github.com/coreos/pkg/capnslog
go: found github.com/coreos/pkg/capnslog in github.com/coreos/pkg v0.0.0-20240122114842-bbd7aa9bf6fb
go: found github.com/coreos/go-systemd/journal in github.com/coreos/go-systemd v0.0.0-20191104093116-d3cd4ed1dbcf
The above resolution results in these legacy versions to be added;
github.com/coreos/etcd v3.3.27+incompatible // indirect
github.com/coreos/go-systemd v0.0.0-20191104093116-d3cd4ed1dbcf // indirect
github.com/coreos/pkg v0.0.0-20240122114842-bbd7aa9bf6fb // indirect
However, none of those are _used_, and they don't appear as vendored file.
That change happens with v3.5.7 and up, but nothing immediately stands
out what change causes this. Possibly it's due to the switch to go1.17
in go.mod, which is the first version that flattened indirect dependencies,
potentially causing intermediate dependency versions to be used during
resolution; etcd-io/etcd@server/v3.5.6...server/v3.5.7
changelog: https://github.com/etcd-io/etcd/blob/f0187c38d1828a3241984c976a3cd2fd4749afc6/CHANGELOG/CHANGELOG-3.5.md
full diff: etcd-io/etcd@server/v3.5.6...server/v3.5.16
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vvoland
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendor: go.etcd.io/etcd v3.5.16
This dependency comes from SwarmKit, but didn't update dependencies
for quite some time. Update the dependencies to their latest patch
release.
Keeping the server at v3.5.6, because newer versions pull in some
odd dependencies (but not used in code).
changelog: https://github.com/etcd-io/etcd/blob/f0187c38d1828a3241984c976a3cd2fd4749afc6/CHANGELOG/CHANGELOG-3.5.md
full diff: etcd-io/etcd@v3.5.6...v3.5.16
vendor: go.etcd.io/etcd/server/v3 v3.5.16
This dependency comes from SwarmKit, but didn't update dependencies
for quite some time. Update the dependencies to their latest patch
release.
For some reason, updating this dependency brings back various legacy
versions of dependencies through
github.com/coreos/etcd/clientv3/concurrency;The above resolution results in these legacy versions to be added;
However, none of those are used, and they don't appear as vendored file.
That change happens with v3.5.7 and up, but nothing immediately stands
out what change causes this. Possibly it's due to the switch to go1.17
in go.mod, which is the first version that flattened indirect dependencies,
potentially causing intermediate dependency versions to be used during
resolution; etcd-io/etcd@server/v3.5.6...server/v3.5.7
changelog: https://github.com/etcd-io/etcd/blob/f0187c38d1828a3241984c976a3cd2fd4749afc6/CHANGELOG/CHANGELOG-3.5.md
full diff: etcd-io/etcd@server/v3.5.6...server/v3.5.16