Bump to golang 1.12.9 by thaJeztah · Pull Request #2880 · moby/swarmkit

thaJeztah · 2019-08-19T19:28:46Z

Did the bump in two steps, so that I can cherry-pick the intermediate 1.11.13 bump into older branches

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah · 2019-08-19T19:28:56Z

thaJeztah · 2019-08-19T20:49:58Z

Weird failures; is Go 1.12 truncating strings using an ellipsis?

--- FAIL: TestTemplatedConfig (0.01s)
    getter_test.go:562: 
        	Error Trace:	getter_test.go:562
        	Error:      	Error message not equal:
        	            	expected: "failed to expand templated config templatedconfig: template: expansion:1:13: executing \"expansion\" at <secret \"unknowntarge...>: error calling secret: secret target unknowntarget not found"
        	            	actual  : "failed to expand templated config templatedconfig: template: expansion:1:13: executing \"expansion\" at <secret \"unknowntarget\">: error calling secret: secret target unknowntarget not found"

oh; the reverse actually; it's looking for <secret \"unknowntarge...>, but gets <secret \"unknowntarget\">

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah · 2019-08-19T21:25:22Z

time="2019-08-19T21:11:05Z" level=debug msg="(*worker).Update" len(assignments)=6
time="2019-08-19T21:11:05Z" level=debug msg="(*worker).reconcileSecrets" len(removedSecrets)=2 len(updatedSecrets)=0
time="2019-08-19T21:11:05Z" level=debug msg="(*worker).reconcileConfigs" len(removedConfigs)=2 len(updatedConfigs)=0
time="2019-08-19T21:11:05Z" level=debug msg="(*worker).reconcileTaskState" len(removedTasks)=2 len(updatedTasks)=0
PASS
time="2019-08-19T21:11:05Z" level=error msg="task manager failed to report status to agent" error="database not open" module=taskmanager service.id= task.id=task-2
panic: Log in goroutine after TestWorkerUpdate has completed

goroutine 1175 [running]:
testing.(*common).logDepth(0xc00019a100, 0xc0000396a0, 0x1d, 0x3)
	/usr/local/go/src/testing/testing.go:634 +0x51a
testing.(*common).log(...)
	/usr/local/go/src/testing/testing.go:614
testing.(*common).Log(0xc00019a100, 0xc00006fb00, 0x1, 0x1)
	/usr/local/go/src/testing/testing.go:642 +0x79
github.com/docker/swarmkit/agent.(*mockTaskController).Remove(0xc00020a780, 0x13b6f40, 0xc0000b4010, 0x13b6f40, 0xc0000b4010)
	/home/circleci/.go_workspace/src/github.com/docker/swarmkit/agent/worker_test.go:604 +0x8e
github.com/docker/swarmkit/agent.reconcileTaskState.func1(0xc0004dac60)
	/home/circleci/.go_workspace/src/github.com/docker/swarmkit/agent/worker.go:270 +0x137
created by github.com/docker/swarmkit/agent.reconcileTaskState
	/home/circleci/.go_workspace/src/github.com/docker/swarmkit/agent/worker.go:313 +0x1a6f
FAIL	github.com/docker/swarmkit/agent	4.244s
make: *** [coverage] Error 1
Exited with code 2

Relates to golang/go#29388, may need something like moby/moby#39197

thaJeztah · 2019-08-19T21:44:51Z

Error is triggered by https://github.com/docker/swarmkit/blob/486ad69951868792367a503042ef3f55b399cc40/agent/worker.go#L313

Which calls closemanager in a goroutine, where the logging can happen https://github.com/docker/swarmkit/blob/486ad69951868792367a503042ef3f55b399cc40/agent/worker.go#L259-L277

thaJeztah · 2019-08-19T21:49:54Z

interestingly this commit 596e0f9 removed the go routine when starting closemanager, but this commit added it back 6379ef0 (without removing the new goroutine inside closemanager)

``` panic: Log in goroutine after TestWorkerUpdate has completed goroutine 1175 [running]: testing.(*common).logDepth(0xc00019a100, 0xc0000396a0, 0x1d, 0x3) /usr/local/go/src/testing/testing.go:634 +0x51a testing.(*common).log(...) /usr/local/go/src/testing/testing.go:614 testing.(*common).Log(0xc00019a100, 0xc00006fb00, 0x1, 0x1) /usr/local/go/src/testing/testing.go:642 +0x79 github.com/docker/swarmkit/agent.(*mockTaskController).Remove(0xc00020a780, 0x13b6f40, 0xc0000b4010, 0x13b6f40, 0xc0000b4010) /home/circleci/.go_workspace/src/github.com/docker/swarmkit/agent/worker_test.go:604 +0x8e github.com/docker/swarmkit/agent.reconcileTaskState.func1(0xc0004dac60) /home/circleci/.go_workspace/src/github.com/docker/swarmkit/agent/worker.go:270 +0x137 created by github.com/docker/swarmkit/agent.reconcileTaskState /home/circleci/.go_workspace/src/github.com/docker/swarmkit/agent/worker.go:313 +0x1a6f FAIL github.com/docker/swarmkit/agent 4.244s make: *** [coverage] Error 1 Exited with code 2 ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

codecov · 2019-08-19T22:07:21Z

Codecov Report

Merging #2880 into master will decrease coverage by 0.04%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2880      +/-   ##
==========================================
- Coverage   62.22%   62.17%   -0.05%     
==========================================
  Files         139      139              
  Lines       22346    22345       -1     
==========================================
- Hits        13904    13893      -11     
- Misses       6962     6969       +7     
- Partials     1480     1483       +3

dperny · 2019-08-20T14:22:07Z

thank you based sebastiaan 🙌 💯 🙌

full diff: moby/swarmkit@7dded76...a8bbe7d changes included: - moby/swarmkit#2867 Only update non-terminal tasks on node removal - related to moby/swarmkit#2806 Fix leaking task resources when nodes are deleted - moby/swarmkit#2880 Bump to golang 1.12.9 - moby/swarmkit#2886 Bump vendoring to match current docker/docker master - regenerates protobufs - moby/swarmkit#2890 Remove hardcoded IPAM config subnet value for ingress network - fixes [ENGORC-2651] Specifying --default-addr-pool for docker swarm init is not picked up by ingress network Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

…v18.09) full diff: moby/swarmkit@142a737...5c86095 - moby/swarmkit#2892 [18.09 backport] Remove hardcoded IPAM config subnet value for ingress network - backport of moby/swarmkit#2890 Remove hardcoded IPAM config subnet value for ingress network - fixes [ENGORC-2651](https://docker.atlassian.net/browse/ENGORC-2651) - moby/swarmkit#2836 [18.09 backport] Switch to go 1.11 - backport of moby/swarmkit#2752 Switch to go 1.11 - moby/swarmkit#2901 [18.09 backport] Bump to golang 1.12.9 - backport of moby/swarmkit#2880 Bump to golang 1.12.9 - moby/swarmkit#2900 [18.09 backport] Fix update out of sequence and increase max recv gRPC message size for nodes and secrets - backport of moby/swarmkit#2762 Increased wait time on test utils WaitForCluster and WatchTaskCreate - backport of moby/swarmkit#2771 Allow using Configs as CredentialSpecs - **second commit only** (attempt to fix weirdly broken tests) - backport of moby/swarmkit#2808 Fix flaky tests - backport of moby/swarmkit#2866 Swap gometalinter for golangci-lint - backport of moby/swarmkit#2869 Increase max recv gRPC message size to initialize connection broker - related / similar to moby#38103 / docker-archive#102 cluster: set bigger grpc limit for array requests - related / similar to moby#39306 Increase max recv gRPC message size for nodes and secrets - fixes moby/swarmkit#2733 Error generated when messages size is too big - backport of moby/swarmkit#2870 Fix update out of sequence Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

full diff: moby/swarmkit@7dded76...a8bbe7d changes included: - moby/swarmkit#2867 Only update non-terminal tasks on node removal - related to moby/swarmkit#2806 Fix leaking task resources when nodes are deleted - moby/swarmkit#2880 Bump to golang 1.12.9 - moby/swarmkit#2886 Bump vendoring to match current docker/docker master - regenerates protobufs - moby/swarmkit#2890 Remove hardcoded IPAM config subnet value for ingress network - fixes [ENGORC-2651] Specifying --default-addr-pool for docker swarm init is not picked up by ingress network Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

…v18.09) full diff: moby/swarmkit@142a737...5c86095 - moby/swarmkit#2892 [18.09 backport] Remove hardcoded IPAM config subnet value for ingress network - backport of moby/swarmkit#2890 Remove hardcoded IPAM config subnet value for ingress network - fixes [ENGORC-2651](https://docker.atlassian.net/browse/ENGORC-2651) - moby/swarmkit#2836 [18.09 backport] Switch to go 1.11 - backport of moby/swarmkit#2752 Switch to go 1.11 - moby/swarmkit#2901 [18.09 backport] Bump to golang 1.12.9 - backport of moby/swarmkit#2880 Bump to golang 1.12.9 - moby/swarmkit#2900 [18.09 backport] Fix update out of sequence and increase max recv gRPC message size for nodes and secrets - backport of moby/swarmkit#2762 Increased wait time on test utils WaitForCluster and WatchTaskCreate - backport of moby/swarmkit#2771 Allow using Configs as CredentialSpecs - **second commit only** (attempt to fix weirdly broken tests) - backport of moby/swarmkit#2808 Fix flaky tests - backport of moby/swarmkit#2866 Swap gometalinter for golangci-lint - backport of moby/swarmkit#2869 Increase max recv gRPC message size to initialize connection broker - related / similar to moby/moby#38103 / docker-archive/engine#102 cluster: set bigger grpc limit for array requests - related / similar to moby/moby#39306 Increase max recv gRPC message size for nodes and secrets - fixes moby/swarmkit#2733 Error generated when messages size is too big - backport of moby/swarmkit#2870 Fix update out of sequence Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: e06f07ef337ab890f211397d6b408b75a2512dc5 Component: engine

thaJeztah added 2 commits August 19, 2019 21:22

Bump Golang 1.11.13

daf8720

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Bump Golang 1.12.9

be528e8

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Update tests for new output with Go 1.12

43fac9c

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah force-pushed the bump_golang branch from 509d1f9 to 43fac9c Compare August 19, 2019 21:08

dperny merged commit 958d149 into moby:master Aug 20, 2019

thaJeztah mentioned this pull request Sep 18, 2019

bump swarmkit to a8bbe7de43b42fc3a8430819ed577e1218dc64aa moby/moby#39953

Closed

thaJeztah mentioned this pull request Sep 25, 2019

[18.09 backport] Bump to golang 1.12.9 #2901

Merged

kolyshkin mentioned this pull request Sep 25, 2019

[WIP RFC] agent/reconcileTaskState: wait for closeManager #2906

Closed

thaJeztah deleted the bump_golang branch September 26, 2019 16:12

thaJeztah mentioned this pull request Oct 2, 2019

[18.09 backport] integration-cli: fix swarm tests flakiness docker-archive/engine#346

Merged

dperny mentioned this pull request Dec 13, 2019

Bump swarmkit to 24fb4cfe8af56803640180c5592bf32da732ced2 moby/moby#40309

Merged

thaJeztah mentioned this pull request Dec 31, 2019

Revert "YOLO see if this works" #2920

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump to golang 1.12.9#2880

Bump to golang 1.12.9#2880
dperny merged 4 commits intomoby:masterfrom
thaJeztah:bump_golang

thaJeztah commented Aug 19, 2019

Uh oh!

thaJeztah commented Aug 19, 2019

Uh oh!

thaJeztah commented Aug 19, 2019

Uh oh!

thaJeztah commented Aug 19, 2019 •

edited

Loading

Uh oh!

thaJeztah commented Aug 19, 2019

Uh oh!

thaJeztah commented Aug 19, 2019

Uh oh!

codecov bot commented Aug 19, 2019

Uh oh!

dperny commented Aug 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

thaJeztah commented Aug 19, 2019

Uh oh!

thaJeztah commented Aug 19, 2019

Uh oh!

thaJeztah commented Aug 19, 2019

Uh oh!

thaJeztah commented Aug 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaJeztah commented Aug 19, 2019

Uh oh!

thaJeztah commented Aug 19, 2019

Uh oh!

codecov bot commented Aug 19, 2019

Codecov Report

Uh oh!

dperny commented Aug 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thaJeztah commented Aug 19, 2019 •

edited

Loading