Skip to content

Move boltdb/bolt to go.etcd.io/bbolt#2748

Merged
anshulpundir merged 1 commit intomoby:masterfrom
lowenna:boltdb
Sep 21, 2018
Merged

Move boltdb/bolt to go.etcd.io/bbolt#2748
anshulpundir merged 1 commit intomoby:masterfrom
lowenna:boltdb

Conversation

@lowenna
Copy link
Copy Markdown
Member

@lowenna lowenna commented Sep 13, 2018

Signed-off-by: John Howard jhoward@microsoft.com

There's a bunch of PRs in various moby and docker related repos, but essentially this to get all the components in moby/moby which are using the unmaintained boltdb/bolt database, which has a bug on Windows, moved to the current maintained fork: specifically release v1.3.1-etcd.8 of go.etcd.io.

moby/moby#37843 has links to the related PRs. Once all related ones are merged, it will resolve this comment: moby/moby#37843 (comment))

@thaJeztah PTAL.

Signed-off-by: John Howard <jhoward@microsoft.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 14, 2018

Codecov Report

Merging #2748 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2748      +/-   ##
==========================================
+ Coverage   61.77%   61.78%   +0.01%     
==========================================
  Files         134      134              
  Lines       21890    21890              
==========================================
+ Hits        13522    13525       +3     
+ Misses       6911     6902       -9     
- Partials     1457     1463       +6

@lowenna
Copy link
Copy Markdown
Member Author

lowenna commented Sep 18, 2018

ping @yongtang - PTAL. Thanks :)

Copy link
Copy Markdown
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as boltdb/bolt has been archived now.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not a maintainer)

@thaJeztah
Copy link
Copy Markdown
Member

ping @dperny @anshulpundir PTAL

@anshulpundir anshulpundir merged commit 3044c57 into moby:master Sep 21, 2018
tiborvass pushed a commit to tiborvass/docker that referenced this pull request Sep 22, 2018
This also brings in these PRs from swarmkit:
- moby/swarmkit#2691
- moby/swarmkit#2744
- moby/swarmkit#2732
- moby/swarmkit#2729
- moby/swarmkit#2748

Signed-off-by: Tibor Vass <tibor@docker.com>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Sep 22, 2018
This also brings in these PRs from swarmkit:
- moby/swarmkit#2691
- moby/swarmkit#2744
- moby/swarmkit#2732
- moby/swarmkit#2729
- moby/swarmkit#2748

Signed-off-by: Tibor Vass <tibor@docker.com>
Upstream-commit: cce1763d57b5c8fc446b0863517bb5313e7e53be
Component: engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants