Revert "Suppor the init for container spec"#2384
Closed
andrewhsu wants to merge 1 commit intomoby:masterfrom
andrewhsu:rm-oneof
Closed
Revert "Suppor the init for container spec"#2384andrewhsu wants to merge 1 commit intomoby:masterfrom andrewhsu:rm-oneof
andrewhsu wants to merge 1 commit intomoby:masterfrom
andrewhsu:rm-oneof
Conversation
This reverts commit fe60f09. Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Author
Author
|
Nuts. I'm too slow on this. #2383 already exists. |
Codecov Report
@@ Coverage Diff @@
## master #2384 +/- ##
==========================================
+ Coverage 60.5% 60.53% +0.02%
==========================================
Files 128 128
Lines 26268 26260 -8
==========================================
+ Hits 15893 15896 +3
- Misses 8971 8975 +4
+ Partials 1404 1389 -15 |
Contributor
|
New PR #2386 is opened with revised impl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit fe60f09.
Should not be creating a new
oneofwith just one field. https://developers.google.com/protocol-buffers/docs/proto#oneofSigned-off-by: Andrew Hsu andrewhsu@docker.com