Skip to content

Revert "Merge pull request #2350 from AliyunContainerService/init-sup…#2383

Merged
anshulpundir merged 1 commit intomoby:masterfrom
anshulpundir:revert
Sep 21, 2017
Merged

Revert "Merge pull request #2350 from AliyunContainerService/init-sup…#2383
anshulpundir merged 1 commit intomoby:masterfrom
anshulpundir:revert

Conversation

@anshulpundir
Copy link
Contributor

@anshulpundir anshulpundir commented Sep 21, 2017

Signed-off-by: Anshul Pundir anshul.pundir@docker.com

…port"

This reverts commit 3882d21, reversing
changes made to 6716ddf.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "revert" git@github.com:anshulpundir/swarmkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

…-support"

This reverts commit 3882d21, reversing
changes made to 6716ddf.

Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
@codecov
Copy link

codecov bot commented Sep 21, 2017

Codecov Report

Merging #2383 into master will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2383      +/-   ##
==========================================
+ Coverage    60.5%   60.64%   +0.14%     
==========================================
  Files         128      128              
  Lines       26268    26260       -8     
==========================================
+ Hits        15893    15925      +32     
+ Misses       8971     8943      -28     
+ Partials     1404     1392      -12

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu
Copy link

@anshulpundir anshulpundir merged commit 6f23ba5 into moby:master Sep 21, 2017
@stevvooe
Copy link
Contributor

LGTM

denverdino pushed a commit to AliyunContainerService/swarmkit that referenced this pull request Nov 5, 2017
…-support" (moby#2383)

This reverts commit 3882d21, reversing
changes made to 6716ddf.

Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants