orchestrator/update: Update spec version when rolling back#2309
Merged
aaronlehmann merged 1 commit intomoby:masterfrom Jul 20, 2017
Merged
orchestrator/update: Update spec version when rolling back#2309aaronlehmann merged 1 commit intomoby:masterfrom
aaronlehmann merged 1 commit intomoby:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2309 +/- ##
==========================================
+ Coverage 60.11% 60.27% +0.15%
==========================================
Files 128 128
Lines 25891 25863 -28
==========================================
+ Hits 15565 15588 +23
+ Misses 8947 8894 -53
- Partials 1379 1381 +2 |
Contributor
|
LGTM, with the caveat that I am not super familiar with this code, but it makes sense and the updated test fails without the change. |
There is an oversight in this code that prevents it from changing the spec version to match the spec that's put in place during a rollback. This could cause a service not to get rolled back all the way. Currently, tasks may stay on the new version until they fail and are replaced with an older version. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
f2e0ef6 to
0538dde
Compare
This was referenced Jul 25, 2017
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
- moby/swarmkit#2288 (Allow updates of failed services with restart policy "none") - moby/swarmkit#2304 (Reset restart history when task spec changes) - moby/swarmkit#2309 (updating the service spec version when rolling back) - moby/swarmkit#2310 (fix for slow swarm shutdown) Signed-off-by: Ying <ying.li@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
- moby/swarmkit#2309 (updating the service spec version when rolling back) - moby/swarmkit#2310 (fix for slow swarm shutdown) - moby/swarmkit#2323 (run watchapi server on all managers) Signed-off-by: Ying <ying.li@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Feb 3, 2020
- moby/swarmkit#2309 (updating the service spec version when rolling back) - moby/swarmkit#2310 (fix for slow swarm shutdown) - moby/swarmkit#2323 (run watchapi server on all managers) Signed-off-by: Ying <ying.li@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Feb 3, 2020
- moby/swarmkit#2288 (Allow updates of failed services with restart policy "none") - moby/swarmkit#2304 (Reset restart history when task spec changes) - moby/swarmkit#2309 (updating the service spec version when rolling back) - moby/swarmkit#2310 (fix for slow swarm shutdown) Signed-off-by: Ying <ying.li@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Mar 10, 2020
- moby/swarmkit#2309 (updating the service spec version when rolling back) - moby/swarmkit#2310 (fix for slow swarm shutdown) - moby/swarmkit#2323 (run watchapi server on all managers) Signed-off-by: Ying <ying.li@docker.com>
glours
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Mar 11, 2020
- moby/swarmkit#2288 (Allow updates of failed services with restart policy "none") - moby/swarmkit#2304 (Reset restart history when task spec changes) - moby/swarmkit#2309 (updating the service spec version when rolling back) - moby/swarmkit#2310 (fix for slow swarm shutdown) Signed-off-by: Ying <ying.li@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Mar 17, 2020
- moby/swarmkit#2288 (Allow updates of failed services with restart policy "none") - moby/swarmkit#2304 (Reset restart history when task spec changes) - moby/swarmkit#2309 (updating the service spec version when rolling back) - moby/swarmkit#2310 (fix for slow swarm shutdown) Signed-off-by: Ying <ying.li@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Mar 23, 2020
- moby/swarmkit#2288 (Allow updates of failed services with restart policy "none") - moby/swarmkit#2304 (Reset restart history when task spec changes) - moby/swarmkit#2309 (updating the service spec version when rolling back) - moby/swarmkit#2310 (fix for slow swarm shutdown) Signed-off-by: Ying <ying.li@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Mar 23, 2020
- moby/swarmkit#2309 (updating the service spec version when rolling back) - moby/swarmkit#2310 (fix for slow swarm shutdown) - moby/swarmkit#2323 (run watchapi server on all managers) Signed-off-by: Ying <ying.li@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an oversight in this code that prevents it from changing the
spec version to match the spec that's put in place during a rollback.
This could cause a service not to get rolled back all the way.
Currently, tasks may stay on the new version until they fail and are
replaced with an older version.
cc @cpuguy83 @thaJeztah