Adds Docker Image v1 Spec Documention #9560

jlhawn · 2014-12-08T07:27:49Z

Docker-DCO-1.1-Signed-off-by: Josh Hawn josh.hawn@docker.com (github: jlhawn)

jlhawn · 2014-12-08T07:31:32Z

From issue #9538:

If you were to complain that Docker's image format and runtime specification, as massively adopted as it is, is not appropriately documented, and it could be made easier to produce alternate implementations - then I would completely agree with you. In response, I would encourage the project maintainers to improve the specs documentation based on your suggestions.

Well, here it is 🐋

@SvenDowideit @fredlf Please review and give feedback.

jessfraz · 2014-12-08T18:54:30Z

😍

jlhawn · 2014-12-08T18:55:26Z

also @vbatts @dmp42 @crosbymichael @tianon @jfrazelle @unclejack @docker/distribution-trust @nathanleclaire @cpuguy83 @huslage and anyone else in the community that comes across this - please read through it and comment on anything that isn't clear or anything that requires more explanation, keeping in mind that this is not a new specification but is only documentation of how images are currently create/formatted in Docker.

I was thinking we could also generate a list of 'issues' with this specification to include in the bottom - something that could help us drive design of the next major version of the specification. Here are a few things I can think of for example:

- image IDs are an implementation detail of storage drivers in Docker and shouldn't be part of the specification.
- there is extraneous or useless info in some of the fields:
    - container id?
    - config *and* containerConfig? containerConfig seems to be only useful for the build system and nothing else.
- why is OnBuild in the runConfig and not top-level in the image JSON?
- is every field of the `runconfig.Config` struct necessary or useful?
- etc...

jlhawn · 2014-12-08T18:59:50Z

also @metalivedev ;-)

icecrime · 2014-12-08T19:28:16Z

image/spec/v1.md

This container config has been a strong point of confusion for me and several others. As far as I can tell:

This provide defaults values for settings if not specified at run time (e.g: CpuShares)

Some of these settings are completely ignored (e.g.: Tty, Attach*, ...)

As far as I understand, this whole idea of "default container config" is out of v2 image format so although this is a purely v1 documentation, don't you think it might be relevant to add a "deprecation warning"?

good points @icecrime

I mentioned above:

is every field of the runconfig.Config struct necessary or useful?

I can update this document to clarify this - only I'm not entirely sure which fields are ignored. I guess I can dig up the code to find out exactly what's going on: https://github.com/docker/docker/blob/58ce0146e16e2e63b7a94d34a48722a9c7400c18/daemon/daemon.go#L418

Do you happen to know which fields are used? @erikh I think you have some expertise with runconfig, could you shed any light on this?

I think it's all in runconfig.Merge. Fields used:

Cmd

CpuShares

Entrypoint

Env

ExposedPorts (and its legacy counterpart PortSpecs)

Memory

MemorySwap

User

Volumes

WorkingDir

metalivedev · 2014-12-09T19:04:17Z

image/spec/v1.md

Suggested: "The filenames prefixed with .wh. are known as "whiteout" files."

Is the name the only indication of the special nature of these files? That is, if I had a file named .wh.somename actually in my tree, would the file be unpacked to the layer? I'm kind of hoping there is some permissions bit or something set that together with the name means it is a special file.

jamescarr · 2014-12-09T21:19:14Z

👍 this is great to see!

jlhawn · 2014-12-10T00:44:23Z

I've just pushed a major update to the draft spec. Please review again if you already have!

tiborvass · 2014-12-10T00:50:25Z

image/spec/v1.md

I find this pretty hard to understand.

Do you think it'd be okay to just delete the second sentence of this paragraph? I realize I probably went a little crazy in the second sentence... we really should agree on some common terminology though. It's a bit confusing to have a single term used loosely to refer to multiple things :(

Do you think we could force a definition and make sure we use that everywhere?

I'm okay with the first sentence definition if everyone else is.

I would phrase it something like this:

Images are composed of "layers". "Image layer" is a general term which may be used to refer to one or both of the following:

The metadata for the layer, described in the JSON format

The filesystem changes described by a layer

To refer to the former specifically, the terms "Layer JSON" or "Layer Metadata" are frequently used.

To refer to the latter, the terms "Image Filesystem Changeset" or "Image Diff" are frequently used.

WDYT?

sounds good to me, @nathanleclaire I'll update it.

mmdriley · 2014-12-10T01:54:43Z

image/spec/v1.md

"image or image layer" -- this seems odd. Do images and image layers have IDs in different namespaces?

Need the image ID necessarily be random, or is the assertion simply that it need not have semantic meaning?

If random, must the ID be from a CSPRNG?

nathanleclaire · 2014-12-10T02:02:44Z

cc @jamtur01 would be great to get your input on this

mmdriley · 2014-12-10T02:06:28Z

image/spec/v1.md

It seems like any description of whiteout files and their semantics is going to #include the implementation details of a specific version of aufs, with specific config/compilation flags, along with the flags Docker invokes it with. For example, this paragraph from the aufs documentation:

The whiteout is for hiding files on lower branches. Also it is applied to stop readdir going lower branches. The latter case is called ’opaque directory.’ Any whiteout is an empty file, it means whiteout is just an mark. In the case of hiding lower files, the name of whiteout is ’.wh..’ And in the case of stopping readdir, the name is ’.wh..wh..opq’ or ’.wh.__dir_opaque.’ The name depends upon your compile configuration CONFIG_AUFS_COMPAT. All whiteouts are hardlinked, including ’/.wh..wh.aufs.’

I'd rm the bit about whiteout files (cover it later) and phrase like:

An archive of the files which have been added, changed, or deleted in an image layer. Using a layer-based or union filesystem such as AUFS, or by computing the diff from filesystem snapshots, the filesystem changeset can be used to present a series of image layers as if it were one cohesive filesystem.

mmdriley · 2014-12-23T23:46:54Z

image/spec/v1.md

Are these double-quotes normative?

I probably shouldn't have included the quotes in this example. I believe the way this value should be interpreted is that the substring before the first = is the variable name and everything after is the value. In Docker, I think this is passed directly to the execution driver in this format. @crosbymichael could you clarify this for us please?

tianon · 2014-12-24T05:49:14Z

image/spec/v1.md

All the following are valid:

user

uid

user:group

uid:gid

uid:group

user:gid

If group/gid is not specified, the default group and supplementary groups of the given user/uid in /etc/passwd from the container are applied.

thanks @tianon !

mmdriley · 2015-01-01T23:41:02Z

lgtm. No doubt there are still nits to be picked, but this is a great step forward in unambiguously-described behavior. Thanks for your time and effort in compiling it.

crosbymichael · 2015-01-05T19:16:08Z

@jlhawn Any more edits remaining?

There is no reason for shykes to look at this if you are just documenting the reality of the current system.

shykes · 2015-01-05T19:21:02Z

Correct, if we're documenting today's design don't feel obligated to wait for my +1

jlhawn · 2015-01-05T19:28:45Z

@crosbymichael I think I just need to add in the User field description from @tianon and we're set!

bfirsh · 2015-01-12T12:34:12Z

This is brilliant. Thanks @jlhawn. I'm really glad we're taking steps towards specifying how Docker works.

Perhaps we could this in for Docker 1.5 and shout about it a bit. ^_^

jessfraz · 2015-01-12T15:07:00Z

I don't know what we are waiting on @jlhawn

jessfraz · 2015-01-12T15:07:32Z

Maybe just a squash of commits?

@jamtur01

Many iterations have gone into documenting a v1 specification of Docker's Image format. v1 Image spec: clarify parent field - metalivedev pointed out that the description was ambiguous, so I've removed mention that it was randomly generated. It IS the ID of the parent image. Updated v1 image specificatino documentation - More complete details and deprication notifications for each field in the JSON metadata of an image. - Details on the format for packaging combined Image JSON + Filesystem Changeset archives for all layers of an image. Clarify description of an image "Layer" in v1 spec Updated intro of image v1 spec Updated image v1 spec after more review - Removed description of "Image" from the terminology section. The entire document is meant to serve this purpose. - Updated the definition of "Image Filesystem Changeset". - Clarified the level of randomness needed for generating image IDs. - Updated the description of "Image Checksum". - Added term descriptions for "Repository" and "Tag" - Removed extraneous/implementation-specific fields from the Image JSON example file and field descriptions: - removed "container_config" and "docker_version" fields. - Added missing "author" field example and description. - Removed extraneous/implementation-specific fields from the "config" struct example and description: - removed "Hostname", "Domainname", "Cpuset", "AttachStdin", "AttachStdout", "AttachStderr", "PortSpecs", "Tty", "OpenStdin", "StdinOnce", "Image", "NetworkDisabled", and "OnBuild". - Updated example Image JSON config with better example values for "Env", "Cmd", "Volumes", "WorkingDir", "Entrypoint", "CpuShares", "Memory", "MemorySwap", and "User". - Added notices that any fields not specified are to be considered as implementation specific and should be ignored my implementations which are unable to interpret them. - Updated example of creating layer filesystem changesets to use less formal language. - Listed more details in the section regarding extraction of a bundle of image layers into the root filesystem of a container. - Updated the closing mention of Docker as an evolving implementation. More updates to the v1 image spec - Added line wrapping after 80 columns per line to adhere to documentation style guides, as pointed out by @jamtur01 - Removed references to any specific docker commands, updated a few descriptions or drop repeated statements, as pointed out by @cpuguy83 Cleanup image v1 spec draft after fredlf comments Address comments by mmdriley on v1 image spec Improve description of image v1 spec 'config.User` - Improves description of image v1 specification for the 'User' runtime parameter after recomendations by tianon. Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)

jlhawn · 2015-01-12T18:41:23Z

@jfrazelle All squashed!

Adds Docker Image v1 Spec Documention

jessfraz · 2015-01-12T18:41:52Z

awesome!

thaJeztah · 2015-01-12T18:43:01Z

Thanks @jlhawn!

odino · 2015-01-15T09:23:56Z

I was talking to @shykes about this at the dockercon in amsterdam...great job guys!

jlhawn force-pushed the image_spec branch 3 times, most recently from 3997360 to 82f5917 Compare December 8, 2014 08:31

jessfraz added the /project/doc label Dec 8, 2014

jlhawn added Distribution labels Dec 8, 2014

icecrime reviewed Dec 8, 2014
View reviewed changes

jlhawn mentioned this pull request Dec 9, 2014

Image checksums computed using tarsum v1 #9215

Closed

metalivedev reviewed Dec 9, 2014
View reviewed changes

jlhawn force-pushed the image_spec branch 2 times, most recently from fcaaef4 to e073386 Compare December 10, 2014 00:43

tiborvass reviewed Dec 10, 2014
View reviewed changes

jlhawn force-pushed the image_spec branch from 5d92a6b to 8366746 Compare December 10, 2014 01:52

mmdriley reviewed Dec 10, 2014
View reviewed changes

mmdriley reviewed Dec 23, 2014
View reviewed changes

jlhawn force-pushed the image_spec branch from 5acaed2 to c816e95 Compare December 24, 2014 01:27

tianon reviewed Dec 24, 2014
View reviewed changes

jessfraz added the docs-only label Jan 6, 2015

jlhawn force-pushed the image_spec branch from c816e95 to a1e3b04 Compare January 12, 2015 06:19

jlhawn force-pushed the image_spec branch from a1e3b04 to 7991062 Compare January 12, 2015 18:40

jessfraz pushed a commit that referenced this pull request Jan 12, 2015

Merge pull request #9560 from jlhawn/image_spec

0192b6c

Adds Docker Image v1 Spec Documention

jessfraz merged commit 0192b6c into moby:master Jan 12, 2015

SvenDowideit mentioned this pull request Jan 27, 2015

Post 1.4.1 docs update 2 #9739

Merged

jlhawn mentioned this pull request Feb 18, 2015

Need to define a format for container image config #10753

Closed

jlhawn deleted the image_spec branch July 31, 2015 18:03

This was referenced Aug 30, 2023

image/spec: Add Go structs #46363

Merged

image/spec: minor fixes and touch-ups in markdown files #46370

Merged

image/specs: add missing OnBuild (v1.0), ArgsEscaped (v1.1), and Shell (v1.2) fields #46371

Merged

Adds Docker Image v1 Spec Documention #9560

Adds Docker Image v1 Spec Documention #9560

Uh oh!

Conversation

jlhawn commented Dec 8, 2014

Uh oh!

jlhawn commented Dec 8, 2014

Uh oh!

jessfraz commented Dec 8, 2014

Uh oh!

jlhawn commented Dec 8, 2014

Uh oh!

jlhawn commented Dec 8, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jamescarr commented Dec 9, 2014

Uh oh!

jlhawn commented Dec 10, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nathanleclaire commented Dec 10, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mmdriley commented Jan 1, 2015

Uh oh!

crosbymichael commented Jan 5, 2015

Uh oh!

shykes commented Jan 5, 2015

Uh oh!

jlhawn commented Jan 5, 2015

Uh oh!

bfirsh commented Jan 12, 2015

Uh oh!

jessfraz commented Jan 12, 2015

Uh oh!

jessfraz commented Jan 12, 2015

Uh oh!

jlhawn commented Jan 12, 2015

Uh oh!

jessfraz commented Jan 12, 2015

Uh oh!

thaJeztah commented Jan 12, 2015

Uh oh!

odino commented Jan 15, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects