Skip to content

Rename hack to project#9178

Merged
shykes merged 1 commit intomoby:masterfrom
shykes:hack-to-project
Nov 14, 2014
Merged

Rename hack to project#9178
shykes merged 1 commit intomoby:masterfrom
shykes:hack-to-project

Conversation

@shykes
Copy link
Copy Markdown
Contributor

@shykes shykes commented Nov 14, 2014

This depends on #9177

Move 'hack' to the less confusing 'project'
32e61b8 
We might want to break it up into smaller pieces (eg. tools in one
place, documents in another) but let's worry about that later.

Signed-off-by: Solomon Hykes <solomon@docker.com>
@shykes shykes mentioned this pull request Nov 14, 2014
Merged
erikh
erikh reviewed Nov 14, 2014
View reviewed changes
CONTRIBUTING.md Outdated
Copy link
Copy Markdown
Contributor

@erikh erikh Nov 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to update the link for this heading in the table of contents above.

@shykes
Copy link
Copy Markdown
Contributor Author

shykes commented Nov 14, 2014

@tianon ok?

@shykes
Copy link
Copy Markdown
Contributor Author

shykes commented Nov 14, 2014

@tianon I fixed the trailing / in the symlink, just for you :)

@tianon
Copy link
Copy Markdown
Member

tianon commented Nov 14, 2014

LGTM except the minor cosmetics of having hack be a symlink to project/ instead of just project:

$ ls -lFd hack
lrwxrwxrwx 1 tianon tianon 8 Nov 14 16:20 hack -> project//
$ rm hack && ln -s project hack
$ ls -lFd hack
lrwxrwxrwx 1 tianon tianon 7 Nov 14 16:20 hack -> project/

@tianon
Copy link
Copy Markdown
Member

tianon commented Nov 14, 2014

Yessss LGTM ❤️

shykes pushed a commit that referenced this pull request Nov 14, 2014
Merge pull request #9178 from shykes/hack-to-project
b7ca8f6 
Rename hack to project
@shykes shykes merged commit b7ca8f6 into moby:master Nov 14, 2014
@crosbymichael
Copy link
Copy Markdown
Contributor

crosbymichael commented Nov 14, 2014

HAHHAHAHHAHAHAHAH

@jessfraz
Copy link
Copy Markdown
Contributor

jessfraz commented Nov 14, 2014

What's so funny

On Friday, November 14, 2014, Michael Crosby notifications@github.com
wrote:

HAHHAHAHHAHAHAHAH

—
Reply to this email directly or view it on GitHub
#9178 (comment).

@tianon
Copy link
Copy Markdown
Member

tianon commented Nov 15, 2014

For those who didn't follow the joke through to libcontainer: docker-archive/libcontainer#265 (comment)

@jessfraz
Copy link
Copy Markdown
Contributor

jessfraz commented Nov 15, 2014

lol we keep things entertaining here ;) on the next episode of maintaining
docker...

On Fri, Nov 14, 2014 at 11:09 PM, Tianon Gravi notifications@github.com
wrote:

For those who didn't follow the joke through to libcontainer: docker-archive/libcontainer#265
(comment)
docker-archive/libcontainer#265 (comment)

—
Reply to this email directly or view it on GitHub
#9178 (comment).

@erikh
Copy link
Copy Markdown
Contributor

erikh commented Nov 15, 2014

Do I get to be Kramer?

On Nov 15, 2014, at 6:38 AM, Jessie Frazelle notifications@github.com wrote:

lol we keep things entertaining here ;) on the next episode of maintaining
docker...

On Fri, Nov 14, 2014 at 11:09 PM, Tianon Gravi notifications@github.com
wrote:

For those who didn't follow the joke through to libcontainer: docker-archive/libcontainer#265
(comment)
docker-archive/libcontainer#265 (comment)

—
Reply to this email directly or view it on GitHub
#9178 (comment).

—
Reply to this email directly or view it on GitHub #9178 (comment).

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Nov 15, 2014

Sure! Will this do?

Erik Kramer

(Hm, think I need to stop doing this 😄)

@erikh
Copy link
Copy Markdown
Contributor

erikh commented Nov 15, 2014

Strangely apropos.

On Nov 15, 2014, at 12:08 PM, Sebastiaan van Stijn notifications@github.com wrote:

Sure! Will this do?

https://camo.githubusercontent.com/a28ef5d42c9d0964f77685eac8fd6723f2b5cc2a/687474703a2f2f692e67697068792e636f6d2f514d6c64653848567a4c54416b2e676966
(Hm, think I need to stop doing this )

—
Reply to this email directly or view it on GitHub #9178 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shykes @tianon @crosbymichael @jessfraz @erikh @thaJeztah