rebased and corrected tests.

@unclejack @proppy can you please test that localhost does not need insecure registry flag?

@tiborvass I'm on it, the tests are passing and I'm going to test the change now.

@unclejack @proppy can you please test that localhost does not need insecure registry flag?

This is already tested here:

        {"127.0.0.1:5000", []string{"127.0.0.1:5000"}, false},
+       {"localhost", []string{}, false},
+       {"localhost:5000", []string{}, false},
+       {"127.0.0.1", []string{}, false},

The updated behavior treats all 127.0.0.1/localhost references as insecure, so technically, it’s testing something different. I’d like to leave it in.

On Nov 12, 2014, at 2:37 PM, Johan Euphrosine notifications@github.com wrote:

@unclejack https://github.com/unclejack @proppy https://github.com/proppy can you please test that localhost does not need insecure registry flag?

This is already tested here:

    {"127.0.0.1:5000", []string{"127.0.0.1:5000"}, false},

•   {"localhost", []string{}, false},
  

•   {"localhost:5000", []string{}, false},
  

•   {"127.0.0.1", []string{}, false},
  

  —
  Reply to this email directly or view it on GitHub Secure localhost registry (carry of #8898) #9124 (comment).

I confirm this works as expected. LGTM

localhost works without requiring --insecure-registry, non-localhost requires --insecure-registry, --insecure-registry works as intended and pulling from the Hub still works properly with this PR.

LGTM

Someone please merge when you're ready

KAPOW!

OI! where's the documentation for this?

@SvenDowideit for the record, I rewrote the whole section: tiborvass@5937663

It's from #9100