registry_test.go still needs updates to the new NewEndpoint interface

./registry_test.go:24: cannot use false (type bool) as type []string in argument to NewEndpoint
./registry_test.go:36: cannot use false (type bool) as type []string in argument to NewEndpoint

Didn't I open a PR for tests on endpoint? Or do you mean additional tests?
On Nov 11, 2014 5:56 PM, "Derek McGowan" notifications@github.com wrote:

registry_test.go still needs updates to the new NewEndpoint interface

—
Reply to this email directly or view it on GitHub
#9104 (comment).

@dmcgowan @vbatts @proppy Fixed it. PTAL

LGTM

@tiborvass this is a pure refactor right? no functional changes?

Mainly potential bugfix: https://github.com/docker/docker/blob/master/registry/service.go#L43
If addr has a form like the one that IndexServerAddress() returns (i.e. https://index.docker.io/v1/), then it is different from the domain:port form that IsSecure expects.

Additionally, I realized that the only places where we use IsSecure is before a call to NewEndpoint. Since we could make use of the URL parsing in newEndpoint, I thought it could be good to refactor it.

Something I feel is missing, is a test reflecting the potential issue this fixes.

functionality and stylistically LGTM and I expect tests to be forthcoming in another PR?

Rebased

Added a commit that fixes a bug with isSecure and IndexServerAddress().

@vbatts @dmcgowan let me know if this new commit is fine for you, or if you prefer that I parse IndexServerAddress() and make the check against someParseFunction(IndexServerAddress()).URL.Host

@vbatts @dmcgowan I actually did the latter, making sure that it is isSecure's responsibility to always return true for the index.

I ended up doing what @proppy initially suggested (seems like a recurring theme now :P). I'm passing insecureRegistries to newEndpoint as well.

Not sure if the drone error is related...

LGTM