Allow IPC namespace to be shared between containers or with the host#9074
Allow IPC namespace to be shared between containers or with the host#9074crosbymichael merged 1 commit intomoby:masterfrom
Conversation
|
Originally #8211 This takes most of the comments in from Michaels Pull. Only big one is around whether or not we should capitalize IPC or leave it Ipc. I think there could be some more doc changes. |
|
Awesome. I'll try to take another look at this later today. |
|
The build seems to have failed in a totally random place. |
There was a problem hiding this comment.
This example with a custom C binary and what not feels kind of awkward.
There was a problem hiding this comment.
Well the test programs is just reading link to /proc/1/ns/ipc and making sure they are the same, which indicates you are in the same IPC namespace.
|
This is starting to look great! |
|
|
Yes I have no idea why? Seems to be not related to patch. |
3317098 to
64b18fc
Compare
|
LGTM |
|
LGTM. I am all for mentioning real-world applications/use-cases in the docs. As long as we are not advocating or discussing blatantly commercial/proprietary products and/or services, real-world examples are more helpful, IMHO, than abstractions. |
|
Looks like an errant patch. |
|
Had to add some fixes for SELinux labels. |
Some workloads rely on IPC for communications with other processes. We would like to split workloads between two container but still allow them to communicate though shared IPC. This patch mimics the --net code to allow --ipc=host to not split off the IPC Namespace. ipc=container:CONTAINERID to share ipc between containers If you share IPC between containers, then you need to make sure SELinux labels match. Docker-DCO-1.1-Signed-off-by: Dan Walsh <dwalsh@redhat.com> (github: rhatdan)
|
LGTM |
|
Oh, forgot to mention that IPC should be capitalized, as per style guide. http://docs.docker.com/contributing/docs_style-guide/#abbreviations-and-acronyms |
|
ping @unclejack @jfrazelle Please review |
|
LGTM |
Allow IPC namespace to be shared between containers or with the host
Some workloads rely on IPC for communications with other processes. We
would like to split workloads between two container but still allow them
to communicate though shared IPC.
This patch mimics the --net code to allow --ipc=host to not split off
the IPC Namespace. ipc=container:CONTAINERID to share ipc between containers
If you share IPC between containers, then you need to make sure SELinux labels
match.
Docker-DCO-1.1-Signed-off-by: Dan Walsh dwalsh@redhat.com (github: rhatdan)