Update vendor'd libcontainer and update to use new user interface.#9023
Conversation
libcontainer/user to use new interfacelibcontainer and update to use new user interface.
hack/vendor.sh
Outdated
There was a problem hiding this comment.
Unrelated formatting changes... tsk tsk 😄
There was a problem hiding this comment.
Haha, sorry. I set vim to strip whitespace when a file is saved. 😜
fb272d0 to
1e26e50
Compare
This patch updates the vendor'd libcontainer version, so that Docker can take advantage of the updates to the `user` API. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com> (github: cyphar)
1e26e50 to
5e0c889
Compare
This patch fixes the compilation errors in Docker due to changes in the libcontainer/user API. There is no functionality change due to this patch. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com> (github: cyphar)
5e0c889 to
3ac4aa0
Compare
|
hack and vendor changes LGTM cc @tiborvass |
There was a problem hiding this comment.
what does GetGroupFile error message look like?
There was a problem hiding this comment.
@proppy "user lookup: operating system does not provide passwd-formatted data" is the only error produced by the user/lookup API.
There was a problem hiding this comment.
just a optional suggestion, that you may want to add more context to the error (i.e: mentioning GetGroupFile). But that's up to you really.
LGTM for api/server
There was a problem hiding this comment.
@proppy The error was written like that because if an operating system doesn't provide a /etc/group-like file it doesn't provide any passwd-formatted data. There's nothing unique to the error about GetGroupFile.
|
LGTM |
|
/cc @unclejack @tiborvass |
|
LGTM |
…face Update vendor'd `libcontainer` and update to use new `user` interface.
This patchset transitions the use of the old libcontainer/user interface
to the new and improved libcontainer/user interface (also updating the
hack/vendor.sh script to use libcontainer:4ae31b6ceb2c2557c9f05f42da61b0b808faa5a4).
Signed-off-by: Aleksa Sarai cyphar@cyphar.com (github: cyphar)
/cc @vieux @tianon
[This is a dup of docker#7591, but my commits won't update when
--forceing my rebases, so just use this one instead.]