Skip to content

Fix a bug which caused builds to fail if ADD was the first command#895

Merged
shykes merged 1 commit into
masterfrom
build-fixes
Jun 15, 2013
Merged

Fix a bug which caused builds to fail if ADD was the first command#895
shykes merged 1 commit into
masterfrom
build-fixes

Conversation

@shykes

@shykes shykes commented Jun 14, 2013

Copy link
Copy Markdown
Contributor

No description provided.

@ghost ghost assigned creack Jun 14, 2013
@shykes

shykes commented Jun 14, 2013

Copy link
Copy Markdown
Contributor Author

@creack can you double-check real quick? It's cherry-picked from multiple fixes, so you should double-check that it works for you.

Since it's a hotfix for @unclejack and it's getting late in Europe for @vieux, let's bend the rules on this one and merge after you review.

@creack

creack commented Jun 14, 2013

Copy link
Copy Markdown
Contributor

it has been fixed within #848, but as hotfix, it works fine.

@shykes

shykes commented Jun 14, 2013

Copy link
Copy Markdown
Contributor Author

I think you only fixed half of it in #848.

On Fri, Jun 14, 2013 at 4:29 PM, Guillaume J. Charmes <
notifications@github.com> wrote:

it has been fixed within #848#848,
but as hotfix, it works fine.


Reply to this email directly or view it on GitHubhttps://github.com//pull/895#issuecomment-19486956
.

@creack

creack commented Jun 14, 2013

Copy link
Copy Markdown
Contributor

Cmd + Image: https://github.com/dotcloud/docker/pull/848/files#L1R222
The image you added in commit() is not necessary as it is already set at the beginning of the function (l261).
Or did I miss something?

@unclejack

Copy link
Copy Markdown
Contributor

ADD seems to be broken even if it's not the first command:

Caching Context 10240/? (n/a)
FROM ubuntu:12.04 ()
===> 8dbd9e392a964056420e5d58ca5cc376ef18e2de93b5cc90e868a1bbc8318c1c
RUN true (8dbd9e392a964056420e5d58ca5cc376ef18e2de93b5cc90e868a1bbc8318c1c)
===> 9fda0b14a0bb308ece6b8ad37768e6e07bd955fd775e80e201b0a9afcd5ebbbc
ADD ./mysql.sh /root/mysql.sh (9fda0b14a0bb308ece6b8ad37768e6e07bd955fd775e80e201b0a9afcd5ebbbc)
Error build: No command specified

shykes pushed a commit that referenced this pull request Jun 15, 2013
- Builder: fix a bug which caused builds to fail if ADD was the first command
@shykes shykes merged commit 30f6045 into master Jun 15, 2013
@shykes shykes deleted the build-fixes branch June 15, 2013 16:24
shykes pushed a commit that referenced this pull request Jun 15, 2013
thaJeztah pushed a commit to wanghuaiqing2010/moby that referenced this pull request May 8, 2026
Source external DNS queries from container namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants