Skip to content

Fix ps -s hang#8010

Merged
unclejack merged 3 commits intomoby:masterfrom
LK4D4:fix_ps_s_hang_#7999
Sep 15, 2014
Merged

Fix ps -s hang#8010
unclejack merged 3 commits intomoby:masterfrom
LK4D4:fix_ps_s_hang_#7999

Conversation

@LK4D4
Copy link
Copy Markdown
Contributor

@LK4D4 LK4D4 commented Sep 12, 2014

Fixes #7999

Signed-off-by: Alexandr Morozov <lk4d4math@gmail.com>
Fixes #7999

Signed-off-by: Alexandr Morozov <lk4d4math@gmail.com>
Signed-off-by: Alexandr Morozov <lk4d4math@gmail.com>
@erikh
Copy link
Copy Markdown
Contributor

erikh commented Sep 12, 2014

LGTM, but I'm not sure how this fixes the issue. Can you explain it?

@LK4D4
Copy link
Copy Markdown
Contributor Author

LK4D4 commented Sep 12, 2014

@erikh There is lock on each container in daemon.Containers and if size is true, then it calls container.GetSize which calls container.Changes which tires to lock again - BOOM, deadlock.

@erikh
Copy link
Copy Markdown
Contributor

erikh commented Sep 12, 2014

Aha… Thanks.

On Sep 12, 2014, at 8:43 AM, Alexandr Morozov notifications@github.com wrote:

@erikh There is lock on each container in daemon.Containers and if size is true, then it calls container.GetSize which calls container.Changes which tires to lock again - BOOM, deadlock.


Reply to this email directly or view it on GitHub.

@jessfraz
Copy link
Copy Markdown
Contributor

LGTM

@unclejack
Copy link
Copy Markdown
Contributor

LGTM

unclejack added a commit that referenced this pull request Sep 15, 2014
@unclejack unclejack merged commit c751e17 into moby:master Sep 15, 2014
@LK4D4 LK4D4 deleted the fix_ps_s_hang_#7999 branch September 15, 2014 12:23
@WIZARD-CXY
Copy link
Copy Markdown

LGTM

@moby moby locked and limited conversation to collaborators Oct 12, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker ps -sa hangs

5 participants