-
Notifications
You must be signed in to change notification settings - Fork 18.9k
Remove deprecated server package #7497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
shykes
commented
Aug 9, 2014
- Move "pull" to graph/pull.go
- Move "push" to graph/push.go
- Move "build" to daemon/build.go
- Remove the deprecated server package
- Simplify daemon creation: call NewDaemon() straight from main()
|
Ping @crosbymichael @tibor @LKD4D @unclejack Note: legacy Unit tests and CLI integration tests seem to pass well. |
|
Pretty much fails :) I'll take a look. |
|
I indeed, don't see why the MTU and network init configs should not be done inside NewDaemon. |
|
Thanks @tiborvass, that was it. For now I'm leaving a FIXME to cleanup how Ready for review. |
|
This depends no #7496. |
|
LGTM, but don't merge before #7496 |
|
Ping |
|
LGTM |
|
This has a commit (with a different commitid) from the PR #7496 that has already been merged. Not sure if it's a problem. |
|
@tiborvass it should be removed I think |
|
@shykes do you have time to rebase this PR? |
|
Yes will do this afternoon On Monday, August 11, 2014, Michael Crosby notifications@github.com wrote:
|
Signed-off-by: Solomon Hykes <solomon@docker.com>
|
Rebased |
|
@shykes gofmt failed |
Victory! Signed-off-by: Solomon Hykes <solomon@docker.com>
|
#@^%#*@&^@^$@ fixed |
|
LGTM |
|
LGTM |
Remove deprecated server package