Conversation
|
LGTM |
|
ping @tianon can you please check last one time that is the best |
|
LGTM ❤️ Do you want to add me to the MAINTAINERS for that file since it dovetails nicely with the Dockerfile? |
|
don't give @tianon the power |
api/client/commands.go
Outdated
There was a problem hiding this comment.
Why is this ignored if the error is not nil ?
There was a problem hiding this comment.
It's not a problem for me, .dockerignore is just an helper, if we can't read it, it's ok, we ignore it. @unclejack ?
There was a problem hiding this comment.
We would error out above because of ValidateContextDirectory right now anyway, so I don't think this changes anything. Perhaps we should warn that ValidateContextDirectory will detect the unreadable .dockerignore?
There was a problem hiding this comment.
I would print out a warning on stderr if err != nil
|
Another +1 for this. I'm developing with Vagrant, and deploying via Docker to AWS Elastic Beanstalk. Problem is, AWS needs the Dockerfile to be in the root of the Git repo being deployed. This means the Unless there's another workaround I am stuck manually deploying |
+ go test github.com/dotcloud/docker/archive
# github.com/dotcloud/docker/archive
./archive_test.go:180: undefined: TarFilter
FAIL github.com/dotcloud/docker/archive [build failed]
Tests failed: ./archive |
Docker-DCO-1.1-Signed-off-by: Travis Cline <travis.cline@gmail.com> (github: tmc)
Fixes moby#2224 Docker-DCO-1.1-Signed-off-by: Travis Cline <travis.cline@gmail.com> (github: tmc)
Docker-DCO-1.1-Signed-off-by: Victor Vieux <vieux@docker.com> (github: vieux)
Docker-DCO-1.1-Signed-off-by: Victor Vieux <vieux@docker.com> (github: vieux)
Docker-DCO-1.1-Signed-off-by: Victor Vieux <vieux@docker.com> (github: vieux)
|
@crosbymichael please retry |
|
@tmc can you add some docs ? |
|
LGTM |
1 similar comment
|
LGTM |
|
ping @SvenDowideit Sorry I merged a little too quickly. Can we do another PR for the docs? |
|
😍 anxious to see that released, thanks! |
There was a problem hiding this comment.
Change to single back-ticks. Also below.
Close #4165
Fixes #2224