allow docker build - to accept a context tar from stdin#5715
allow docker build - to accept a context tar from stdin#5715vieux merged 1 commit intomoby:masterfrom
Conversation
|
That's cool, but won't this conflict with the current behavior of How would you see these 2 behaviors co-existing? |
|
Also check out |
|
@shykes they are already coexisting, it See proppy@7457af7 If it's |
|
About I need access to the |
|
added docs, PTAL |
|
Fixed Docs, PTAL |
|
Fixed docs, PTAL. |
|
nice. Docs LGTM |
|
@proppy Didn't you see any performance issue with |
|
@creack PTAL removed the bufio stuff from |
|
@proppy Could you rebase interactively and not add it in the first place, please? |
|
@unclejack Done, PTAL |
|
@unclejack PTAL cleaned up the history. |
There was a problem hiding this comment.
This needs an empty line at the end.
|
@proppy Could you also add tests for piping in uncompressed tarballs and piping in a Dockerfile, please? |
api/client/commands.go
Outdated
There was a problem hiding this comment.
This would detect uncompressed tarballs as a Dockerfile. You need to make any necessary adjustments to the length of the magic to make it work for uncompressed tarballs and do something like if archive.DetectCompression(magic) == archive.Uncompressed && !archive.IsTarball(magic) { while taking the sizing of the required magic into account for each function.
|
@unclejack Done, PTAL |
|
@proppy Can you rebase this PR one more time, please? |
|
@unclejack squashed and rebased |
|
LGTM |
|
ping @vieux |
|
rebased |
Docker-DCO-1.1-Signed-off-by: Johan Euphrosine <proppy@google.com> (github: proppy)
|
LGTM |
1 similar comment
|
LGTM |
allow docker build - to accept a context tar from stdin
This allow things like
docker build -t builder ; (docker run builder | docker build -t runner -)