docs: fix broken docker docs links in CONTRIBUTING.md#52228
Merged
Conversation
thaJeztah
reviewed
Mar 25, 2026
| quickly. If your pull request is not accepted on the first try, | ||
| don't get discouraged! Our contributor's guide explains [the review process we | ||
| use for simple changes](https://docs.docker.com/contribute/overview/). | ||
| use for simple changes](https://github.com/moby/moby/blob/master/project/REVIEWING.md). |
Member
There was a problem hiding this comment.
Perhaps link to both https://github.com/moby/moby/blob/master/docs/contributing/README.md (which I think was the previous link) and reviewing process?
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion, @thaJeztah! That makes perfect sense. I've updated the sentence to include relative links to both the contributor's guide and the reviewing process.
Signed-off-by: Maksim Nikolaev <nmaks2012@yandex.ru>
8397109 to
91cd097
Compare
kovan
added a commit
to kovan/moby
that referenced
this pull request
Mar 26, 2026
Replace two dead docs.docker.com links with correct in-repo paths: - CONTRIBUTING.md: image link pointed to removed docs.docker.com/opensource/project/who-written-for/ page; now links to docs/contributing/who-written-for.md - .github/PULL_REQUEST_TEMPLATE.md: contributing guide link pointed to removed docs.docker.com/opensource/code/ page; now links to docs/contributing/ on GitHub Follow-up to moby#52228 which fixed most broken links but missed these two. Fixes moby#45024 Signed-off-by: Kit Dallege <xaum.io@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed broken (404) links in
CONTRIBUTING.md.- How I did it
Replaced outdated
docs.docker.comURLs with the current valid documentation URLs.- How to verify it
Check the changed lines in
CONTRIBUTING.mdand click the updated links to ensure they resolve correctly to the active documentation pages.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)
🐈