migrate TestAPIImagesSearchJSONContentType to integration test#51560
Open
2003Aditya wants to merge 1 commit intomoby:masterfrom
Open
migrate TestAPIImagesSearchJSONContentType to integration test#515602003Aditya wants to merge 1 commit intomoby:masterfrom
2003Aditya wants to merge 1 commit intomoby:masterfrom
Conversation
robmry
reviewed
Nov 19, 2025
Contributor
robmry
left a comment
There was a problem hiding this comment.
Thank you @2003Aditya ...
integration/image/search_test.go
Outdated
|
|
||
| assert.Equal(t, res.StatusCode, http.StatusOK) | ||
| assert.Equal(t, res.Header.Get("Content-type"), "application/json") | ||
|
|
integration/image/search_test.go
Outdated
Comment on lines
+18
to
+19
| assert.Equal(t, res.StatusCode, http.StatusOK) | ||
| assert.Equal(t, res.Header.Get("Content-type"), "application/json") |
Contributor
There was a problem hiding this comment.
Where possible, it's better to use assert.Check to let the test continue ...
Suggested change
| assert.Equal(t, res.StatusCode, http.StatusOK) | |
| assert.Equal(t, res.Header.Get("Content-type"), "application/json") | |
| assert.Check(t, is.Equal(res.StatusCode, http.StatusOK)) | |
| assert.Check(t, is.Equal(res.Header.Get("Content-type"), "application/json")) |
20e2f6c to
bb8c8fd
Compare
robmry
reviewed
Nov 26, 2025
integration/image/search_test.go
Outdated
| ) | ||
|
|
||
| // https://github.com/moby/moby/issues/14846 | ||
| func TestAPIImagesSearchJSONContentType(t *testing.T) { |
Contributor
There was a problem hiding this comment.
We should probably rename the test to TestImagesSearchJSONContentType.
bb8c8fd to
ebc6c3f
Compare
robmry
approved these changes
Nov 28, 2025
ebc6c3f to
7260b9c
Compare
Signed-off-by: Aditya Mishra <mishraaditya675@gmail.com>
7260b9c to
f9c654c
Compare
Contributor
|
I guess something went wrong with a rebase, the latest diff adds back |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Migrated the
TestAPIImagesSearchJSONContentTypetest fromintegration-cli/docker_api_image_test.goto the new integration test framework underintegration/image/search_test.go.