integration: migrate TestAPIImagesSizeCompatibility to integration test#51564
Merged
robmry merged 1 commit intomoby:masterfrom Dec 5, 2025
Merged
Conversation
robmry
reviewed
Nov 19, 2025
Contributor
robmry
left a comment
There was a problem hiding this comment.
Thank you @2003Aditya ...
integration/image/size_test.go
Outdated
| "gotest.tools/v3/assert" | ||
| ) | ||
|
|
||
| func TestAPIImagesSizeCompatibility(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func TestAPIImagesSizeCompatibility(t *testing.T) { | |
| // Test case for 30027: image size reported as -1 in v1.12 client against v1.13 daemon. | |
| func TestAPIImagesSizeCompatibility(t *testing.T) { |
integration/image/size_test.go
Outdated
| for _, img := range v124Images.Items { | ||
| assert.Assert(t, img.Size != int64(-1)) | ||
| } | ||
|
|
5c89856 to
647f078
Compare
Contributor
|
Thank you for the updates - looks good. There's a Plus the couple of nits above - blank line and the bug ref comment. |
647f078 to
5289321
Compare
Contributor
|
Just the two nits to address on this one (bug ref comment and blank line). And - we should rename the test to |
5289321 to
a8cfa23
Compare
Contributor
|
This one has a merge conflict too (and blank line at the end of the test). |
87324b7 to
fc39b05
Compare
Signed-off-by: Aditya Mishra <mishraaditya675@gmail.com>
fc39b05 to
87583c9
Compare
robmry
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integration-climigration #50159- What I did
Migrated the
TestAPIImagesSizeCompatibilitytest fromintegration-cli/docker_api_image_test.goto the new integration test framework underintegration/image/size_test.go.