client: remove unused Client.HTTPClient() method#51011
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 22, 2025
Merged
Conversation
This method was introduced in [moby/moby@5a84124] related to the (now removed) support for "compose on kubernetes" in the CLI. This functionality extended the CLI with endpoints that are not part of the engine API, but re-using the HTTP-client with the same (TLS) config as the CLI itself. While such scenarios may be something to consider in future (i.e. more easily extend the API with custom endpoints), this method is not currently used, but defined as part of the CLI's interface. This patch removes the method for now, so that we can design from a clean slate in case we need this extensibility, instead of keeping methods that were added ad-hoc around. [moby/moby@5a84124]: moby@5a84124 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vvoland
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client: remove unused
Client.HTTPClient()methodThis method was introduced in moby@5a84124 related to the (now removed) support for "compose on kubernetes" in the CLI. This functionality extended the CLI with endpoints that are not part of the engine API, but re-using the HTTP-client with the same (TLS) config as the CLI itself.
While such scenarios may be something to consider in future (i.e. more easily extend the API with custom endpoints), this method is not currently used, but defined as part of the CLI's interface. This patch removes the method for now, so that we can design from a clean slate in case we need this extensibility, instead of keeping methods that were added ad-hoc around.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)