I don't really see the context of why this would be needed in the mentioned issue.

Also would it be better to add a method to get the HTTP client rather than having the API client itself perform the request? It seems weird to have the API client just do any random request.

I don't really see the context of why this would be needed in the mentioned issue.

It might be a bit hard to follow with much of the context being lost due to the many rebases.
Basically this was suggested by @vdemeester to be able to rewrite docker/cli@0bf781e into docker/cli@05bbb2e

Also would it be better to add a method to get the HTTP client rather than having the API client itself perform the request? It seems weird to have the API client just do any random request.

I really don't have enough experience with the design of moby and docker/CLI to answer that.
However the initial need was indeed a way to get access to the underlying HTTP client in order to use its configuration (mainly credentials), so I'd be happy with a good old GetHTTPClient().
@vdemeester any though on this?

@mat007 yeah having a exported method to get the client's http client would work too 👼

Or something to read the credentials. Is this just the tlsconfig? We could provide a copy of the tlsconfig easily enough.

@cpuguy83 I changed the PR to now expose a HTTPClient getter instead.

Codecov Report

❗ No coverage uploaded for pull request base (master@b7b6b69). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #37071   +/-   ##
=========================================
  Coverage          ?   35.09%           
=========================================
  Files             ?      615           
  Lines             ?    45820           
  Branches          ?        0           
=========================================
  Hits              ?    16080           
  Misses            ?    27630           
  Partials          ?     2110