[28.x backport] Move swarm runtime plugin spec to swarm types#50802
[28.x backport] Move swarm runtime plugin spec to swarm types#50802
Conversation
e90da0b to
7f7b8a0
Compare
|
Hm... actually, I should probably drop the "logdriver" part from this PR; we don't really need it, because it's not part of the API (it was just in the wrong place), but it has external consumers; https://github.com/grafana/loki/blob/f078dc84369150e21f3e9e36cfc20f4879de3560/clients/cmd/docker-driver/driver.go#L16-L17 |
9c89c3b to
b6c4875
Compare
| Disabled bool `json:"disabled,omitempty"` | ||
| Env []string `json:"env,omitempty"` | ||
| } | ||
| type RuntimeSpec = runtime.PluginSpec |
There was a problem hiding this comment.
This is an extra commit in the 28.x branch where I move the types back to their old location, but alias them in the new location. The daemon-code is linked to the new location and names, which can be aliased to the types in the API module if we do a transitional "28.5" release;
I dropped that commit; this PR now only moves the swarm types, which are part of the API, but removing the protobuf parts from those types. |
Move these types back to their old location, but alias in the new location so that any user of the old types would not require to update. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
b6c4875 to
ebbaaf1
Compare
Uh oh!
There was an error while loading. Please reload this page.