Skip to content

Move logdriver interface#50554

Merged
thaJeztah merged 6 commits intomoby:masterfrom
dmcgowan:move-logdriver-interface
Jul 29, 2025
Merged

Move logdriver interface#50554
thaJeztah merged 6 commits intomoby:masterfrom
dmcgowan:move-logdriver-interface

Conversation

@dmcgowan
Copy link
Member

@dmcgowan dmcgowan commented Jul 29, 2025 •
edited by thaJeztah
Loading

The logdriver is not a part of the HTTP API and does not belong in the API module. The package should likely end up in an external repo to support as part of a plugin sdk, keep it as internal until then.

Includes #50553 to tidy up go modules

Go-SDK: remove deprecated `types/plugins/logdriver` and `types/swarm/runtime` packages; plugin-runtime spec is now exposed as `types/swarm.RuntimeSpec` and `types/swarm.RuntimePrivilege`

dmcgowan added 6 commits July 28, 2025 17:27
@dmcgowan
Move swarm runtime plugin spec to swarm types
86190e7 
Signed-off-by: Derek McGowan <derek@mcg.dev>
@dmcgowan
Move swarm runtime plugin storage type to internal
ee24dce 
Signed-off-by: Derek McGowan <derek@mcg.dev>
@dmcgowan
Update logdriver to remove proto definitions
d7cfe97 
Signed-off-by: Derek McGowan <derek@mcg.dev>
@dmcgowan
Move logdriver to internal under daemon/logger
5bbb718 
The logdriver package should be moved to another external repository for
building plugins. While transitioning, move to internal package using
the same structure.

Signed-off-by: Derek McGowan <derek@mcg.dev>
@dmcgowan
Update api go.mod
03d7f47 
Signed-off-by: Derek McGowan <derek@mcg.dev>
@dmcgowan
Update client go.mod
1dc53e8 
Remove transitive gogo dependency

Signed-off-by: Derek McGowan <derek@mcg.dev>
@dmcgowan dmcgowan force-pushed the move-logdriver-interface branch from af5914b to 1dc53e8 Compare July 29, 2025 06:05
vvoland
vvoland approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvoland vvoland added area/api API kind/refactor PR's that refactor, or clean-up code labels Jul 29, 2025
@vvoland vvoland added this to the 29.0.0 milestone Jul 29, 2025
@vvoland vvoland added impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK area/go-sdk and removed area/api API labels Jul 29, 2025
@thaJeztah
Copy link
Member

thaJeztah commented Jul 29, 2025

Test failure is unrelated;

=== Failed
=== FAIL: github.com/docker/docker/integration/container TestContainerRestartWithCancelledRequest (77.67s)
    restart_test.go:278: timeout waiting for restart event

thaJeztah
thaJeztah approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@thaJeztah thaJeztah merged commit 7381c0d into moby:master Jul 29, 2025
309 of 319 checks passed
@thaJeztah thaJeztah deleted the move-logdriver-interface branch July 29, 2025 11:47
This was referenced Aug 4, 2025
Merged
Merged
@austinvazquez austinvazquez mentioned this pull request Aug 5, 2025
Merged
@dmcgowan dmcgowan mentioned this pull request Aug 6, 2025
Closed
@thaJeztah thaJeztah mentioned this pull request Aug 25, 2025
Merged
This was referenced Sep 5, 2025
Merged
Merged
Merged
@dmcgowan dmcgowan mentioned this pull request Sep 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@vvoland vvoland vvoland approved these changes

Assignees

No one assigned

Labels

area/go-sdk impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code

Projects

None yet

Milestone

29.0.0

Development

Successfully merging this pull request may close these issues.

API: types/plugins/logdriver must be removed from API module

3 participants

@dmcgowan @thaJeztah @vvoland